[pull] main from TryGhost:main - #1412
Merged
Merged
Conversation
no ref Ghost [dropped SQLite in production years ago][0]. Developers don't need to test migrations with SQLite. This change should have no user impact. [0]: https://ghost.org/changelog/5/
no ref _I recommend reviewing this [one commit at a time](https://github.com/TryGhost/Ghost/pull/29890/commits)._ This change should have no user impact. This change: - tests email analytics database queries - stops using a global reference to the database, and injects the dependencies (DI) In addition to automated testing, I also manually tested this. I sent a newsletter, opened it in Gmail, and verified that I saw the open appear in the newsletter's analytics.
no ref - update all action references to latest versions - update Docker digest pins to latest (except for mysql) - update pnpm to latest - add renovate rule to pin mysql to v8.x - pin tb-cli to v4.6.13 due to an upstream bug/change
no ref This change should have no user impact. It adds a type declaration for `core/server/data/index.js`.
no ref _I recommend reviewing this [one commit at a time](https://github.com/TryGhost/Ghost/pull/29892/commits)._ This change should have no user impact. This change: - tests the email analytics initializer - stops using global references and injects the dependencies (DI) In addition to automated testing, I also manually tested this. I sent a newsletter, opened it in Gmail, and verified that I saw the open appear in the newsletter's analytics.
This PR contains the following updates: This PR contains the following updates: - autoprefixer@10.5.4 - postcss@8.5.26 Co-authored-by: tryghost-renovate[bot] <269725441+tryghost-renovate[bot]@users.noreply.github.com>
no ref - switch rebaseWhen to 'conflicted', removing the consistent rebase force-push cycle that led to PRs being stuck - widen automerge window to allow for CI re-runs - reduce Renovate log noise by default, allow debug logging on manual runs
no ref - update nx to latest v23 - update secretlint monorepo - update knip/lint-staged/dep-cruiser
Co-authored-by: tryghost-renovate[bot] <269725441+tryghost-renovate[bot]@users.noreply.github.com>
no ref - update vitest et. al to latest - update deps in scripts/* package - update types dependencies
no ref - cleanup remaining jest type-only references (import from Vitest directly) - remove jest/jest types dependency
no ref - pin vitest/ui to catalog - pin prettier to catalog - bump nock/esbuild/prettier/stylelint/typescript-eslint to latest
no ref - remove unnecessary node-fetch/cross-fetch deps from repo, as fetch is available natively in the last few majors of Node
no ref This change should have no impact on functionality. Before this change, we initialized newsletter-specific metrics in `EmailAnalyticsService`, which should be unaware of newsletters. Now, it's moved higher up. I think this is a useful cleanup. _(Note: this PR's branch name is a misnomer, left over from a previous direction.)_
ref #29890 (review) Big picture ----------- We sometimes failed to create the job row for the "missing" job. This could cause: - unnecessary extra fetches from Mailgun - events to be dropped entirely, if the site was off for awhile Details ------- There are four jobs for email analytics: 1. opened 2. non-opened 3. scheduled 4. missing Before this change, `setJobTimestamp` failed to upsert the job row. For the first three job types, it turned out that was fine, because they were already created by previous code paths. But not for the "missing" job! Before this change, we'd only create the "missing" job row when: - no missing events were found - there was an error processing the batch Now, we create it at the right time as intended.
…29963) no ref This fixes several type errors and makes it possible to convert this module to TypeScript. This should have no user impact.
Migrates the remaining Codex documentation into the codebase. This is part of work to bring all codebase docs into the codebase, and make sure the information is consistent, correct and coherent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )