[pull] main from TryGhost:main - #1410
Merged
Merged
Conversation
## What changed - Set Shade's light-mode `--control-border` to a 50% OKLab mix between `gray-200` and `gray-300`. - Applied the same intermediate value to light-mode `--border-default` for bordered containers. - Routed `Card`, `EmptyCard`, and plain-card separators through `border-border-default` explicitly. - Kept the existing dark-mode values unchanged because they are tuned separately for dark surfaces. The shared control token applies consistently to text inputs, textareas, selects, comboboxes, input groups, and other composed form controls. The default border token covers framed containers and dividers, while Card now opts into that semantic border deliberately. ## Why The original gray-200 borders lacked definition, while gray-300 was visually too heavy. The midpoint preserves a quieter hierarchy while still increasing separation from white surfaces. ## Impact This is a backward-compatible visual adjustment. No component APIs, token names, focus states, or dark-mode values change. ## Validation - `pnpm --filter @tryghost/shade lint` - `pnpm --filter @tryghost/shade test` — 296 tests passed - `pnpm --filter @tryghost/shade build-storybook` - Shade token and merge-gate scans [DES-1474](https://linear.app/ghost/issue/DES-1474/bump-form-input-border-color-for-better-contrast)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )