[pull] main from TryGhost:main - #1362
Merged
Merged
Conversation
#29537) closes https://linear.app/ghost/issue/NY-1489/add-nullable-automation-action-revision-id-column-to-redirects _This should have no user impact; this column is currently dormant in the codebase, but we'll be using it soon._ ## Summary - Adds a nullable automation revision foreign key to redirects with ON DELETE SET NULL - Orders schema tables so fresh MySQL databases create referenced tables before their dependents - Keeps nullable automation revisions out of generated redirect seed dependencies
no ref - replaced the legacy admin-x-design-system ConfirmationModal with a settings-local Shade AlertDialog compatibility layer - migrated all settings confirmation flows and removed the old component, export, and story - preserved async labels, caller-owned close behavior, custom and sticky footers, nested-modal Escape handling, and destructive variants - fixed dark-mode Sonner close-button contrast and spacing regressions found during manual validation
closes https://linear.app/ghost/issue/NY-1491/populate-track-clicks-when-sending-automation-emails ## Summary - snapshot the `email_track_clicks` setting when sending automation emails and persist it on the `automated_email_recipients` row - same idea as `track_opens`
no ref - moved the settings LimitModal implementation out of admin-x-design-system - rebuilt it on the Settings-local Shade confirmation dialog - migrated all settings limit prompts to the local component - preserved HTML limit messages and made prompt content use the full modal content width with normal wrapping - added focused coverage for defaults, HTML prompts, sizing, and the upgrade action
no ref - Added a compositional `ModalPage` page template to Shade, with Storybook and unit coverage. - Migrated Portal links, official themes, and advanced theme settings to the Shade template. - Removed the legacy design-system `ModalPage` implementation and exports. - Fixed the Portal settings underline flicker and made preview/sidebar tab synchronization reflect their non-1:1 relationship: - Signup options and Look & feel use the Signup preview. - Account page uses the Account preview. - Links remains an independent preview and does not alter the settings tab.
…Settings (#29540) no ref - managed hosting providers other than Ghost(Pro) see hardcoded "free trial"/"pick a plan" copy and a fixed `#/pro/billing/plans` link in the Access settings pre-launch banner, none of which apply to their platform - adds optional title, error (message) and upgradeUrl fields under the existing hostSettings.limits.publicSiteAccess config, each falling back to Ghost's current default when unset, so behaviour is unchanged unless a host overrides it
no ref - now that Moya has no more core requires, these shims are unused and can be cleaned up
no ref - Added a Shade `PreviewChrome` component with desktop and mobile device variants - Migrated the Design, Announcement bar, and Theme preview surfaces - Added Storybook coverage for both device frames - Removed the legacy `DesktopChrome` and `MobileChrome` components and exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )