[pull] master from cube-js:master - #693
Merged
Merged
Conversation
…1664) * docs: the dashboard controls now live behind an Add Controls menu Filter and Time Granularity used to be two buttons sitting under an "Add Controls:" label in the dashboard-builder toolbar, so the docs told readers to click them directly. They are options inside an "Add Controls" dropdown now — the same shape as the neighbouring "Add Widgets" menu — so the old instruction points at a button that isn't there. Also say the part that isn't guessable from the toolbar: for anything inside a menu, the option itself is what you click or drag, and starting a drag closes the menu so it doesn't cover the canvas. Cloud PR: cubedevinc/cubejs-enterprise#14422 (CUB-2791) * docs: match the sibling pages' menu wording, and fix the lead-in once Review follow-ups: - `text.mdx` and `layout.mdx` both say "open the **Add Widgets** menu in the toolbar and choose X". Say it the same way for **Add Controls**, so the parallel this change creates is visible in the prose too. - "Each toolbar item can be added in two ways" was the inaccurate sentence — most items are menu options now — so correct it there instead of walking it back a paragraph later. What's left is the part the toolbar doesn't show you: starting a drag closes the menu.
…s sharing (#11663) * docs: say what a duplicated workbook does with the original's sharing * docs: document what a duplicate inherits under permission inheritance * docs: move the Duplicates subsection under Permission inheritance * docs: name every Duplicate entry point and link the Duplicates section
* docs: document the Parent dashboard control (CUB-3034) Adds a "Parent" section to the dashboard controls page. A parent control is a dropdown of creator-defined options that re-points a whole row of other controls at once, so a viewer makes one choice instead of adjusting several filters by hand. The page previously opened by asserting there are two control types and that both target a dimension. A parent control targets none — it drives other controls, which then apply themselves to charts — so the intro, the Visibility section (which claimed to cover "both" types) and "Interaction with charts" (where a parent deliberately never appears) all needed correcting rather than just appending to. Also records Parent in the product taxonomy in docs-mintlify/CLAUDE.md, and rewords charts.mdx so its aside no longer reads as a complete definition of what a control is. * docs: address review on the Parent control section - "Controls of the other type still apply" only parsed under the two-type assumption this PR's intro replaced. Name the two types explicitly; the behavior is unchanged, since a parent contributes nothing to a chart query and so can never be the type that gets skipped. - Link the first "Controls mapping" mention, matching the two below it. - Trim three passages that explained why the product behaves as it does rather than how to use it, per the docs conventions: the two-parents rationale (the rule and the editor's warning carry it), the indicator restating its own section opener, and the re-apply-on-load detail behind "defaults line up". * docs: point the Parent instruction at the Add Controls menu Rebased onto #11664, which replaced 'click X under Add Controls in the toolbar' with 'open the Add Controls menu and choose X' for the two existing controls — the buttons are menu options now. The Parent section still carried the old phrasing, which points at a button that isn't there.
…rtitionExist, thanks @dochernyshov (#11617) Polling job status from a replica that never built that data source crashed on this.queue[dataSource].getQueueDriver(). Create the queue via getQueue() first, matching the other queue accessors. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )