[pull] master from cube-js:master - #687
Merged
Merged
Conversation
…multi-stage measures (#11641) * fix(schema-compiler): resolve inherited definitions per cube `extends` hands the extending cube the very definitions of the cube it extends: `allDefinitions` merges the parent's member objects by reference, and a view's `default_filters` reach the extending view through the prototype. References resolved per cube were written into those shared objects, so the last cube prepared won and every other cube ended up carrying member paths of a cube that is not its own. Multi-stage members were hit through their nested `grain` and `filter` objects — `prepareMembers` copies the member itself, but not what hangs off it — which broke every multi-stage measure of the extended cube, including queries that never mention the extending one. A parent's `grain.include: [d]` came out as `["child.d"]`, and planning then either found no join path to that cube or reported the grain dimension as unreachable, naming a dimension the model already declares. The same aliasing hit two more places: a view's default filter resolved to a member of the view extending it, and a pre-aggregation's `outputColumnTypes` names were scoped to the extending cube. Copy each of them before writing the resolved references. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(tesseract): name the grain in the unreachable-dimension report The report for a dimension a multi-stage member reads outside its grain named the member, the dimension, and the declaration that fixes it — all of which the model already says — so a grain holding something else was indistinguishable from a grain the reader believed was right. Spell out the grain the member is computed at. Granularities are named separately (`orders.created_at (month)`) instead of being folded into the symbol name, and the one case a listing cannot disambiguate — the grain carrying the read dimension only under a granularity — gets a sentence of its own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )