Repository navigation
docs(changelog): name 0.5.0's new field on TipDmPayment, not PaymentMetadata - #11
Merged
Merged
Conversation
…etadata The 0.5.0 entry puts `action` on `intent.v1.ChatMetadata.PaymentMetadata`. No such message exists. `proto/intent/v1/model.proto` has `action = 2` and its nested `Action` enum on `ChatMetadata.TipDmPayment`, alongside `location = 1`. The wrong name reached a downstream task description, so a consumer looking for `PaymentMetadata` in the generated code finds nothing. Field number, enum values and the `Unchanged` claim about numbering were all correct; only the message name was wrong, in both places it appears.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.5.0 entry describes
actionas being added tointent.v1.ChatMetadata.PaymentMetadata. That message does not exist.proto/intent/v1/model.protoputsAction action = 2and its nestedActionenum onChatMetadata.TipDmPayment, next to the pre-existingLocation location = 1.Everything else in the entry checks out against the proto and against the sync diff in #10: field number 2, the
DEFAULT = 0/SEND = 1/TIP = 2values, and theUnchangedsection's claim that the message keepslocationon 1 and appends 2. Only the message name is wrong, and it appears twice, once inAddedand once inUnchanged. Both are fixed here.The entry never spells out the sibling
Locationenum's values, so there was nothing to correct there. For the record they areTIPCARD = 0andCHAT = 1, which is whatDEFAULTinfers from.The wrong name propagated into a downstream task description, which is how it surfaced. The consumers are code-payments/code-ios-app#752 and code-payments/code-android-app#1442.
0.5.0 is already tagged and published, so the GitHub release notes generated from this section still carry
PaymentMetadata. Editing that release body is a separate, manual step.