Repository navigation
fix(profile): tint Report and Block menu icons red - #998
Merged
Merged
Conversation
The app's white tint (FlipcashApp.swift) colours menu icons, while a destructive role colours only the title, so Report and Block showed red titles beside white icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On another user's profile, the ⋯ menu drew Report and Block with red titles and white icons. The app sets
.tint(Color.textMain)at the root (FlipcashApp.swift:47); menu icons follow the tint, whilerole: .destructivecolours only the title.Destructive entries now set
.tint(.red)on their button, so the icon matches the title. Mute Notifications and Unblock keep the white tint.