Repository navigation
feat(chat): adopt flipcash2 0.17.0 (group descriptions) - #975
Merged
Merged
Conversation
Add Conversation.description (in-memory), decode MetadataUpdate.DescriptionChanged into the store, and map DESCRIPTION_MODERATED on StartChat and EditChat results.
EditChat models unchanged, set, and clear explicitly via ConversationDescriptionEdit, since the wire tells them apart by whether the wrapper is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: blocked on the flipcash2-client-protocol 0.17.0 release (code-payments/flipcash2-client-protocol#24). Stacked on #974; retarget to
mainonce that merges.Package.resolvedneeds re-resolving against the 0.17.0 tag after it's published.Adopts the 0.17.0 contract (group descriptions), with no UI:
Conversation.description, nil when empty, and adescriptionChangedstream event applied byConversationStore.startChattakes an optionaldescription;editChattakes aConversationDescriptionEdit(unchanged,set,clear), defaulting tounchanged..descriptionModerated(flaggedCategory)onErrorStartChatandErrorEditChat, reported to analytics asDescriptionModerated.Not handled yet: the description is in memory only (no schema bump, unlike the title), no caller sends one, and private-group start has no wrapper to carry it.