Repository navigation
Conversation
Long-pressing a bubble near the top of the transcript moved it down over its own reaction pills before the menu's blur arrived, and the lifted bubble itself did not show once the menu was up. Both come from the lift #898 added: a copy of the bubble in a clear box 71pt taller than the bubble, which UIKit pushes down to keep on screen. Long press goes back to lifting the bubble itself, and the strip goes on whichever side of the bubble the menu isn't, as before #898. For a bubble near the top, that puts the strip below it again. Double tap keeps its own lift and still opens the strip above.
Collaborator
Author
|
Superseded by the PR from fix/chat-lift-bubble-in-place. Dropping the taller lift didn't fix the shift; the inset-mode switch in freezeInset did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-pressing a bubble near the top of the transcript moved it about 31pt down over its own reaction pills before the menu's blur arrived. Once the menu was up, the lifted bubble didn't show, and the strip landed over where it should have been.
Both come from the long-press lift added in #898. It hands UIKit a copy of the bubble in a clear box 71pt taller than the bubble. UIKit pushes that box down to keep it on screen, and the pill row, which isn't in the box, stays behind.
This takes that lift out:
A fix that keeps the strip above on long press is a separate follow-up.