Repository navigation
fix(profile): drop chevrons from rows that don't push - #826
Merged
Merged
Conversation
Every row on the chat and user profile screens opens a sheet, a dialog or a cover. None of them pushes a screen, so the trailing chevron promised a navigation that never happens. Removing it makes `ChatMuteRow.Chevron` dead: the enum existed because the two hosts drew the chevron differently, and neither draws one now. The rows carry their own trailing spacer instead, which is what the accessory had been supplying. Leave Group keeps its loader accessory, and with it that accessory's spacer, so its own spacer is conditional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every row on the chat and user profile screens opens a sheet, a dialog or a full-screen cover. None of them pushes a screen, so the trailing chevron pointed at a navigation that never happens.
What this removes
ChatMuteRow.Chevrongoes with it. The enum existed only because the two hosts drew the chevron differently —Row's own accessory on the chat profile, a smaller secondary glyph on the user profile to match its card — and neither draws one now.ReportRowborrowed the same enum, so both rows lose a parameter and their callers lose an argument.Each row that loses its chevron gains a trailing
Spacer(), becauseRowsupplies the spacer from inside the accessory branch. Without one the label stops filling the width. Leave Group is the exception: it still takes a loader accessory while leaving, so its spacer is conditional on not leaving.Scope
Only rows that push keep a chevron, which on these screens is none of them. The Edit Group list added in #825 pushes both of its rows and is untouched.