Repository navigation
fix(profile): provide ProfileCreationState on every stack - #1002
Merged
Merged
Conversation
ProfileNameScreen and ProfilePhotoScreen read ProfileCreationState from the environment, but only the two tips-stack roots (ChatTab and TipsSheetRoot) provided it. A push of .profileName or .profilePhoto onto the you, balance, give, or buy stack would crash on the missing environment object. Nothing pushes them there today. SessionContainer now owns one ProfileCreationState and injects it with the other session objects, so every stack and sheet finds it. The Chat tab and the tips sheet share one instance instead of each holding its own, and a name typed into the sheet now survives closing it.
…ment Hosts .profileName and .profilePhoto with the app and session environment and nothing stack-local, which is what the you, balance, give, and buy stacks provide. With the ProfileCreationState injection removed, both tests crash on the missing environment object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProfileNameScreenandProfilePhotoScreenreadProfileCreationStatefrom the environment, but only the two tips-stack roots (ChatTabandTipsSheetRoot) provided it. Pushing.profileNameor.profilePhotoonto the you, balance, give, or buy stack would crash on the missing environment object. Nothing pushes them there today;.profileNameis only pushed fromTipsScreen, and nothing pushes.profilePhoto.SessionContainernow owns oneProfileCreationStateand injects it with the other session objects, so every stack and sheet finds it.Behaviour changes:
router[.tips], but each used to hold its own state.SessionContainer, so nothing carries across accounts.