Repository navigation
fix(chat): open the group's profile from an invite card - #1736
Merged
Merged
Conversation
Tapping a group invite card in a transcript opened the group's chat, skipping the profile (cover, members, balance requirements) that the card previews. A resolved card now pushes the group's profile, the way a featured group does: the chat route opens on the profile, and Open Chat there pushes the transcript. A card that is still loading or unavailable keeps opening the chat by id. A link to the chat already on screen still does nothing, and the invite-followed analytics event is unchanged. GroupLinkLookup hands the public record it fetched to FeaturedGroupsStore, so the profile draws from it instead of sitting empty through its own GetChat. The group profile has no origin parameter on Android (it reads whether a chat is underneath), so no new origin value is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a group invite card in a transcript opened the group's chat. It now opens the group's profile when the card has resolved, with Open Chat leading on to the chat; an unresolved card still opens the chat. iOS counterpart: code-payments/code-ios-app#1031