Repository navigation
fix(profile): draw the Scan glyph on the profile card tile - #1734
Merged
Merged
Conversation
The Show Profile Card tile used ic_qr_code; it now draws ic_nav_tipcard, the Scan tab's outline glyph, matching the iOS tile. The tile row also sat almost against the sheet's close button. AppBarWithTitle holds its height at 56dp and ignores the bottom of HeaderPadding, while the top 16dp shifts the close button down past the bar's measured edge, where the list starts. The row now has 28dp above it (iOS's 16 header bottom plus its 12 row inset) and keeps 12 below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1731.
ic_nav_tipcard, the Scan tab's outline glyph from:apps:flipcash:core, instead ofic_qr_code. iOS is making the same change to its tile.ic_qr_codeis still used by the funding buttons, so it stays.AppBarWithTitlekeeps a fixed 56dp height and ignoresHeaderPadding's bottom, while the 16dp top shifts the close button down past the bar's measured edge, which is where the list starts. The row now has 28dp above it, iOS's 16 header bottom plus its 12 row inset, and keeps 12dp below. I changed the row rather than the header becauseheaderHeightalso sizes the bottom scrim, the list's bottom inset and the composer's offset. The group invite sheet shares the row and gets the same gap.