Repository navigation
Conversation
github-actions
Bot
added
type: feature
This was referenced Oct 6, 2026
bmc08gt
added this pull request to stack #1696
October 7, 2026 01:28
ProfileShareSheet draws a title, a subtitle and one row per ProfileShareRow. The caller picks the rows, hosts the sheet and runs the chosen action after it dismisses.
The You tab now opens on the shared profile header with Edit Profile and Share, then the stats card, instead of the tip card with link and tiles. Share opens a sheet with Share Profile, Show Profile Card and Copy Link; the card moves to its own full-screen route that keeps Download. Removes the expansion machinery, the profile checklist and their tests.
The card screen dropped the opaque fill the You-tab card used, so the card read as a faint outline on the flat backdrop, and Close sat clipped against the right edge. Name the flattened tone TipCardFlattened in bills, provide it on the card screen, and host Close in AppBarWithTitle like other full-screen screens.
Both now use the app's CircularIconButton in an untitled AppBarWithTitle, so they sit where other tabs keep their trailing bar button and blur the cover or card behind them.
…es, localize join date Ignore a second share-sheet row tap while the first is dismissing, show the profile card's Download button only once the card exists, build the joined label from the locale's MMMMy pattern, let the profile stats card and action button grow with font scale, and drop the unused ProfileTutorial items, title_finishYourProfile and ic_chevron_down_medium.
The buttons used the action colour (Gray50) at 10%, which barely shows on the dark background. The design calls for a 10% white fill, which is White10.
The stats card centred its two stats vertically and then padded them from the top, so the captions sat well below the 16pt inset iOS uses. Pin the card to 84dp and let each stat fill that height, top-aligned.
bmc08gt
force-pushed
the
feat/profile-refresh-own-profile
branch
from
October 7, 2026 01:56
93311f1 to
b4e5161
Compare
iOS YouScreen draws the header for every account and puts the claim prompt where the stats card goes. Android dropped the header, so an account with no name lost its cover, avatar and Edit Profile button. Share stays hidden until there is a name to share. ProfileHeader also gets iOS's 8pt gap (staticGrid.x2) between the action row and the title, and takes a null title for the unnamed case.
…s iOS does iOS #986 replaced the You tab's username progress card with a one-line "Claim your username ›" under the handle, shown while there is no handle or only an auto-assigned one. The tap keeps the balance gate. The card component and its two strings are gone; the progress state stays, since the gate reads it. The profile card raises a screen dimmer than 0.4 to 0.6 while it is up, as iOS's ProfileCardScreen does, through the KeepScreenOn helper the scanner already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second slice of the profile refresh, matching code-payments/code-ios-app#986 and the header and share sheet from #987–#988: the You tab is now your own profile. Stacked on #1689.
You tab (
features/menu, Figma node 10961:314)CircularIconButtonin the trailing bar slot, blurring the cover behind it.UsernameProgressCardstays.Minimum to Chat
TipPaymentDelegate.minimumToOpenDmWithis renamedstartChattingFee. The stats card and the chat screen read the same value: your own fee converted to your currency, else the regional default.Share sheet and profile card
Menu.ProfileCard. Download sits where the gear was, in the same frosted button, and Close is pinned at the bottom.Shared pieces (
shared/common-ui/.../profile)ProfileCover,ProfileHeader,ProfileStatsCard,ProfileActionButton,ProfileStatusChipandProfileShareSheettake what they draw (aMediaItemcover, an avatar slot, title, subtitle and body, the share rows), not a user ID, so the group profile can reuse them.ChatMuteStatusChipnow draws withProfileStatusChip.Design tokens