Repository navigation
fix(chat-ui): photo close transition, double tap and reply quote follow-ups - #1687
Merged
Merged
Conversation
…op bar The flight back from the viewer ended on one radius for every corner, then snapped to the bubble's grouped corners once it settled. It now animates to the corners the bubble draws (first/middle/last, caption, quote). The flying photo was drawn over the transcript's top bar and bottom composer and only went behind them when the row took over. It is now clipped to the transcript area on the way back, easing out to the full screen only near fully open.
…g press Bubble only attached its gesture handler when a tap or long press was set, so a bubble that only reacts to a double tap never got one.
The overlay clipped the photo hard at the bar's bottom edge, while the bubble it lands on sits under the bar's blur and fade, so the part under the bar appeared in one frame when the overlay went. Over the last fifth of the close the transcript now draws the photo itself, inside the blur and haze, and the overlay's copy fades out as it fades in.
boundsInRoot() clips a layout to its ancestors, so a bubble running past the top of the message list reported only its visible part. The closing photo landed on that shorter rect, and the bubble jumped to its real size when the overlay went. Read the bubble's position and size unclipped.
The quote sat in its own small bubble above the photo, so it read as a separate message. It is now a chip on the photo's top-left, capped at 80% of the photo's width and two lines of text, on a near-opaque ground so it stays readable over bright images.
The chip sat 8dp in from a 12dp corner, which leaves it a 4dp corner that reads as square. It now sits 4dp in, so its corner is 8dp, and the corner nested in the photo's top-start follows that corner when grouping flattens it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #1683 that were pushed after it merged.
Closing a photo from full screen
boundsInRoot()clipped a bubble running under the bar to its visible part, so the photo landed on a smaller rect and the real bubble jumped when it appeared.Double tap
Bubbleonly installed its click handler when it had a tap or long press, so a bubble that only handled double tap dropped it. Double tap on a photo opens the reaction strip again.Photo reply quote
A photo reply's quote is now a chip over the photo's top-left instead of a separate bubble above it: at most 80% of the photo's width, two lines, inset 4 dp with corners concentric with the photo's (
PhotoQuoteCornersTest).