Repository navigation
feat(chat): stack the composer's header, chips and field - #1682
Merged
Merged
Conversation
bmc08gt
force-pushed
the
feat/chat-media-composer
branch
from
October 6, 2026 00:58
893df75 to
b4fb16f
Compare
bmc08gt
force-pushed
the
feat/chat-media-composer
branch
2 times, most recently
from
October 6, 2026 14:33
011af03 to
f628cb5
Compare
The composer layout photos need, without the photos. ChatInput becomes a custom Layout (ComposerMeasurePolicy) that stacks an optional header row (reply strip or photo chips) over the text field and lays out the accessory and send button around it, matching the iOS composer. - composerStacks() decides when the field goes multi-line; it is pure and covered by ComposerStackingTest. - Height changes, the single-line to multi-line switch and the header arriving or leaving all ease on one spring (dampingRatio 1, ~0.28s, the iOS replySurface curve), so the field and its text move together. - Corners stay concentric: the field's corner is the header chip's corner plus the inset, on one line or stacked. - The header strip fades only at an edge it has scrolled past. - Sizes come from the static grid; the one-line field is FieldPadding + AccessorySize + FieldPadding, the same 50dp as the $ button.
bmc08gt
force-pushed
the
feat/chat-media-composer
branch
from
October 6, 2026 14:52
f628cb5 to
2c0132a
Compare
bmc08gt
added this pull request to stack #1685
October 6, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composer layout photos need, without the photos. ChatInput becomes a
custom Layout (ComposerMeasurePolicy) that stacks an optional header row
(reply strip or photo chips) over the text field and lays out the
accessory and send button around it, matching the iOS composer.
covered by ComposerStackingTest.
arriving or leaving all ease on one spring (dampingRatio 1, ~0.28s, the
iOS replySurface curve), so the field and its text move together.
plus the inset, on one line or stacked.
AccessorySize + FieldPadding, the same 50dp as the $ button.
Stacked on #1681.