Repository navigation
feat(chat): show end-to-end encryption status in DMs and groups - #1618
Merged
Merged
Conversation
The E2EE learn-more sheet lists its items with the same icon-and-line row the contacts rationale uses. Moved as-is, with a spacing parameter for the sheet's 12dp gap; existing callers keep grid.x2.
DM profiles get a footer saying messages are end-to-end encrypted when E2eePolicy says the chat is; Group Info always says group chats aren't. Learn More opens a sheet listing what is and isn't encrypted, one for DMs (node 10416:1533) and one for groups (node 10557:1412). The footer is the scaffold's bottom bar rather than MenuList's footer, so it stays at the bottom while the rows scroll. ChatViewModel maps the chat's metadata through E2eePolicy, which stays the only reader of use_e2ee; the policy gains an @Inject constructor for that.
An encrypted message used to render as a tombstone saying it isn't
supported on this version. It now matches node 10416:1576: a dashed
bubble with "This message can't be displayed" and "Update Flipcash to
see it" underneath.
The line underneath is an UndecryptableHint, so decryption can add
"Ask {first name} to send it again" and "Try sending it again" for
messages that fail to open. Only UpdateApp is produced for now.
The DM profile with its footer on, Group Info, both learn-more sheets and the unreadable-message bubble with each hint, written to build/screenshots/ for comparison with nodes 10557:1304, 10557:1643, 10416:1533, 10557:1412 and 10416:1576. Same Robolectric mechanics as ChatIdentityScreenshotTest; the profiles are built from the screens' scaffold, header, rows and footer because the screens take their view models.
Three of the new strings used ’ while the group footer used ', which is what most of strings.xml uses.
github-actions
Bot
added
area: ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI for end-to-end-encrypted DMs, with no crypto behind it yet. Everything reads
use_e2eethroughE2eePolicy, so there's one place that decides whether a chat encrypts.BulletRowmoves from the contacts rationale into:ui:componentsfor this, with a spacing parameter; existing callers keepgrid.x2.EncryptedContentmessage used to render as an "unsupported on this version" tombstone. It's now a dashed bubble reading "This message can't be displayed" (node 10416:1576). The line underneath is anUndecryptableHint; only "Update Flipcash to see it" is produced here, and the stacked PR adds the resend hints.E2eeScreenshotTestandUndecryptableBubbleScreenshotTestrender the profiles, both sheets and the bubble with each hint tobuild/screenshots/for comparison with nodes 10557:1304, 10557:1643, 10416:1533, 10557:1412 and 10416:1576.Phase 2, the encryption itself, is stacked on this branch.