Repository navigation
fix(chat): refetch and label senders with no display name - #1612
Merged
Merged
Conversation
A sender whose cached profile had no name kept a blank row and an empty avatar in the transcript. Any cached row counted as resolved, so it was never fetched again, and the name line was skipped when the name was blank. Accounts created before the onboarding name step have no display name on the server, so this shows up in the ALL chat. - Refetch a sender whose cached name is blank, once per session, for bubbles and reply quotes. - Fall back from display name to handle to "Flipcash User" on the name line, reply quotes, the profile title and the block prompt, matching iOS's ConversationController.fallbackCounterpartName. The avatar keeps the plain gradient instead of drawing initials from the label. - The profile screen uses the fetched profile rather than only its join date, and keeps the cached one if the fetch fails. - Store the handle when the resolver saves a fetched profile. - Skip roster members with no name, picture or handle so a member-list sync cannot erase a profile that was just fetched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sender with no display name showed as a blank row with an empty avatar in the ALL chat, and their profile opened with no name. The account behind it was created in April, before onboarding asked for a name, so the server has none for it.
Two client problems made that worse:
Changes:
ConversationController.fallbackCounterpartName. The avatar keeps the plain gradient, since initials from the label would draw "FU" on every nameless sender.iOS counterpart: code-payments/code-ios-app#901. The checklist step that asks these accounts for a name is in #1613.