Repository navigation
fix(chat): show one reaction strip per link-card message - #1586
Merged
Merged
Conversation
A message split around its link card is two or three rows, and every row of the selected message is focused, so each composed its own quick reaction strip. Only the pressed row hosts the strip now, anchored to the union of the rows' bounds that MessageList collects. The stored reaction pills were also copied onto every row by splitAroundLinkCard (the live overlay already went to the last row only), so a reacted-to message showed its pills under each row. The split now leaves them on the last row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-pressing a message with a link card (e.g. "Join my group https://…") showed the quick reaction strip once per row: a message split around its card is up to three
ContentBubblerows,MessageListfocuses every row of the selected message, and each focused row composed its ownQuickReactionStripPopup.MessageListcollects the window bounds of every row of the selected message, keyed by row, and hands the strip only to the row that was pressed (selection.itemKey). All rows stay focused.QuickReactionStripPlacement.messageBounds), so it sits above the top row, or below the bottom one when there's no room above, instead of between the text and the card.splitAroundLinkCardkeepsreactionPillson the last row only. The live overlay inChatViewModelalready did this, but the stored pills were copied onto every row, so a reacted-to message with no in-flight overlay showed its pills under each row.On an emulator, long-pressing either the text row or the card row of a text + group invite message now shows one strip above the text.