Repository navigation
fix(emojis): run generateEmojiList before KSP - #1582
Merged
Merged
Conversation
The Flipcash2 release build on 059570d failed in :libs:emojis:kspReleaseKotlin: Gradle rejected it for reading generateEmojiList's output in src/main/kotlin without depending on it. #1576 added KSP (for Hilt) to libs/emojis. The build already made every compile*Kotlin task depend on generateEmojiList, but not the new ksp*Kotlin tasks, so the two were unordered and the failure depends on which runs first. Extend the same wiring to ksp*Kotlin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flipcash2 Build and Deploy run on
code/cash(059570d) failed in:libs:emojis:kspReleaseKotlin:#1576 added KSP (for Hilt) to
libs/emojis.build.gradle.ktsalready makes everycompile*Kotlintask depend ongenerateEmojiList, which writes intosrc/main/kotlin, but not the newksp*Kotlintasks. Nothing orders the two, so the release build fails whenever the generator happens to run first; that's what CI hit, and why it doesn't fail every time.This extends the same
dependsOntoksp*Kotlin. With the generated folder deleted, running:libs:emojis:kspReleaseKotlinon its own now runs the generator first; oncode/cashit doesn't.