Repository navigation
chore(claude): give agent prompts a finish line and drop needless stops - #1572
Merged
Merged
Conversation
Several agents and skills described steps but no check that the result works, and a few stopped mid-run to ask about local, reversible edits. Finish lines: - test-gap-finder: generated tests pass testDebugUnitTest - module-scaffolder: the module (and the app, for features) compiles - dep-review: the recommended test plan passes after applying changes - fetch-protos: re-run the build after domain-model edits and scaffolding; Step 4 ran before them - triage: the brief names a root cause with .kt:NN evidence, or states confidence and what is missing; steps may be skipped, and the 2-hop cap on call-chain reading is gone - CLAUDE.md: a default definition of done for code changes Confirmation stops removed: - module-scaffolder no longer asks for dependencies; a subagent can't reach the user, so it returned early - fetch-protos applies domain-model edits, defaults new UserFlags fields to read-only, and scaffolds only when invoked with `scaffold` - dep-review applies changes in a worktree instead of asking first, and no longer runs `gh pr checkout` in the main checkout Push, merge, commit, and release gates are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several agents and skills listed steps but had no check that the result works. A few also stopped mid-run to ask about local edits that are easy to undo.
Finish lines
test-gap-findertestDebugUnitTest; leftover TODO stubs are listedmodule-scaffoldercompileDebugKotlinpasses for the module, and for the app on feature modulesdep-reviewfetch-protostriage.kt:NNevidence, or states confidence and what's missingCLAUDE.md:apps:flipcash:app:compileDebugKotlinsucceedstriagealso drops "follow the steps below exactly" and the 2-hop cap on reading the call chain.Confirmation stops removed
module-scaffolderno longer asks which dependencies to add. It runs as a subagent and can't reach the user, so the question ended the run early. It now adds none and lists likely additions.fetch-protosapplies domain-model edits without asking, defaults newUserFlagsfields to read-only, and scaffolds new RPCs only when invoked withscaffold(e.g./fetch-protos flipcash scaffold).dep-reviewapplies required changes in a worktree created from the PR'sheadRefName, instead of asking first and runninggh pr checkoutin the main checkout.Push, merge, commit, and release gates are unchanged.