Repository navigation
fix(claude): correct stale codebase facts in agent and skill prompts - #1559
Merged
Merged
Conversation
bug-triage still told the agent that RxJava 3 and SQLCipher were in use. RxJava was removed in 715f9ec and no build file declares SQLCipher, so the agent would look for threading and encryption bugs that cannot occur. The async and persistence lines now match CLAUDE.md. dependency-impact named ui:navigation and libs:locale:public as leaking RxJava and coroutines-rx3. Neither declares those api() dependencies. Its list of non-catalog dependencies also named sol4k, which is gone, and webkit, which is in the catalog. Both lines now describe how to find the answer instead of a list that goes stale. pr-reviewer pointed IO work at Dispatchers.IO, while CLAUDE.md says dispatchers are injected through DispatcherProvider. Also drops the all-caps ALWAYS in the release-notes prompt and rewords the "no longer vendored" line in fetch-protos to state the current setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three agent prompts describe a codebase that no longer exists, and current models follow them literally.
CLAUDE.md.ui:navigationleaks RxJava andlibs:locale:publicleaks coroutines-rx3; neither module declares thoseapi()dependencies. Its list of non-catalog dependencies names sol4k (removed) and webkit (libs.androidx.webkit). Both lines now say how to find the answer rather than listing it.Dispatchers.IO, whereCLAUDE.mdsays dispatchers come fromDispatcherProvider. About 50 files still useDispatchers.IOdirectly, so this line is a convention call rather than a factual fix.Two wording changes ride along: the release-notes prompt drops an all-caps
ALWAYS, and fetch-protos states the current artifact setup instead of "no longer vendored here".