Repository navigation
Conversation
The button sat top-right because the bottom belongs to the tab bar, which is hoisted into `AppNavigationBar` and so is not this screen's to position around. `LocalTabBarPadding` is that mechanism: `NavTabBarInsetEntryDecorator` hands each tab-home entry the bar's measured height, and `WalletScreenContent`, `MenuScreenContent` and `ChatsScreen` already clear the bar with it. So both numbers are read off the bar rather than picked. The end inset is `grid.x8`, the horizontal margin `AppNavigationBar` draws `NavigationBar` with, which puts the button's end edge on the bar's. The bottom is `LocalTabBarPadding` plus `grid.x3`, the same gap the bar leaves below itself. The button stays outside the permission `when` (a picked photo needs no camera) and stays hidden while a bill is up. Its haze source is still the inner preview Box, which the button is not inside, so the blur does not sample itself.
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gallery button sat in the scanner's top-right corner, clear of the status bar. The comment there explained the choice: the bottom belongs to the tab bar, which is hoisted into
AppNavigationBar, so a control down there has to be positioned around a bar this screen does not own.LocalTabBarPaddingis that mechanism, and it already exists.NavTabBarInsetEntryDecoratorprovides it per tab-home entry from the bar's measured height, andWalletScreenContent,MenuScreenContentandChatsScreenuse it to clear the bar the same way.So the button moves to
Alignment.BottomEndwith both numbers read off the bar rather than picked:grid.x8, the horizontal marginAppNavigationBardrawsNavigationBarwith, which puts the button's end edge on the bar's;LocalTabBarPadding.current.calculateBottomPadding() + grid.x3, the bar's height plus the same gap the bar leaves below itself.Measured on an emulator at 420dpi, the button and the bar's pill both end at x=975.
Nothing else about the button changes. It stays outside the permission
when, since a picked photo needs no camera and someone who declined the camera is who it is for, and it stays hidden while a bill is up. Its haze source is still the inner previewBox, which the button is not inside, so the blur does not sample itself.