Repository navigation
fix(chat): hide the group's mute on a member's profile - #1548
Merged
Merged
Conversation
A group member's profile opens on ChatProfileScreen with the group as its chat, so the header's muted chip showed the group's mute as if it were the person's. Show the chip only on a tip DM, the same rule the mute row already follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Muting a group, then opening a member's profile from it, showed the member as muted.
A member's profile opens on
ChatProfileScreenwith the group as its chat, soProfileHeader's muted chip read the group'sviewerState. The mute row on that screen was already limited to tip DMs for this reason; the chip now follows the same rule and getsnullviewer state anywhere else.Spacing on a member's profile is unchanged: the chip only reserves its height when there are no shortcuts, and a member's profile always has them.