Repository navigation
fix(scanner): open group chat invites scanned from a QR code - #1535
Merged
Merged
Conversation
Scanning an app.flipcash.com/chat/{uuid} QR code did nothing from the
camera and showed "no code found" from the gallery. The router already
classifies the link as a GroupChatInvite, but isScannable refused it and
Scanner had no destination for it, so it fell through to an empty route
list.
GroupChatInvite is now scannable and opens the same destination as a
tapped invite link: Sheets.Tips, then Messaging.Chat by chat id, which is
the gated preview for someone who is not yet a member. Login and
EmailVerification stay refused, since they carry secrets.
github-actions
Bot
added
area: scanner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scanning an
app.flipcash.com/chat/{uuid}QR code did nothing from the camera and showed "no code found" from the gallery.The router already classifies the link as
GroupChatInvite. The scanner dropped it in two places:DeeplinkType.isScannablelistedGroupChatInviteas refused. The comment there said this was a missing feature, not a security decision.Scanner'sNavigatablebranch had no case for it and fell through toemptyList().GroupChatInviteis now scannable, and the scanner opens the same destination as a tapped invite link:Sheets.Tips, thenMessaging.Chat(ByChatId(chatId)). For someone who isn't a member yet, that chat screen is the gated preview.LoginandEmailVerificationstay refused, since they carry secrets.DeeplinkScanPolicyTestnow expects invites to be scannable.