Repository navigation
fix(messenger): finish the group edit rows, and stop tracking agent state - #1527
Merged
Merged
Conversation
The picture and name rows drew Icons.Outlined.Image and Icons.Outlined.TextFields — stock Material vectors in a list whose neighbouring rows all use drawables the app ships. They now use ic_currencycreator_icon and ic_currencycreator_name, the pair the currency creator's info screen puts against its own Icon and Name steps. Reached through com.flipcash.core.R as CoreR, the alias MyAccountMenuItems — the file this one mirrors — already uses to pull core drawables into a feature.
Both bodies described what the other members would see — "Everyone in this group will see it as ..." — rather than what the button is about to do. They now read "This will change the group name/picture for everyone in it", which names the action and keeps the reach. Dropping the quoted title takes the name body's format argument with it. The field it quoted sits on screen behind the prompt.
.gitignore covers .claude/worktrees/, .claude/plans/ and settings.local.json but not .claude/state/, which is where an agent session writes the working note it reads back after a context compaction. The note was picked up as a new file and merged in #1525. Untracked here and the directory ignored alongside the other .claude paths that are already local-only. The file stays on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes that missed #1525. The first two were pushed to
feat/edit-chat-uiafter it had already squash-merged, so they never reachedcode/cash; the third cleans up a file that reached it and should not have.The edit rows wear the currency creator's glyphs
EditGroupMenuItemsdrewIcons.Outlined.ImageandIcons.Outlined.TextFields— stock Material vectors in a list whose neighbouring rows all use drawables the app ships. They now useic_currencycreator_iconandic_currencycreator_namefrom:apps:flipcash:core, the pair the currency creator's info screen puts against its own Icon and Name steps.Reached through
import com.flipcash.core.R as CoreR, whichMyAccountMenuItems— the file this one mirrors — already uses for the same reason.The confirmation bodies say what the button will do
Both described what other members would see rather than what the reader is about to do:
Everyone in this group will see it as "%1$s"This will change the group name for everyone in itDropping the quoted title takes the name body's format argument with it. The field it quoted sits on screen behind the prompt.
.claude/state/is now ignored.gitignorecovers.claude/worktrees/,.claude/plans/andsettings.local.jsonbut not.claude/state/, which is where an agent session writes the working note it reads back after a context compaction.handoff.mdwas picked up as a new file and merged in #1525. Untracked here and the directory ignored alongside the other.claudepaths that are already local-only.