Repository navigation
fix(tipping): stop the new-chat button flashing blank white after the checkmark - #1466
Merged
Merged
Conversation
… checkmark Resolving a username dispatched `UpdateProcessingState()` alongside `UserResolved`, resetting the button to idle. `CodeButton` reads raw `enabled` for its background, so the fill snapped from the disabled White10 to solid White instantly while the content crossfade was still ~300ms into taking the checkmark away — a blank white button in the frames right before `navigator.replace` opened the chat. The chat replaces this screen, so idle is a state it never shows again. Dropping the reset holds the checkmark until the screen goes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving a username on the new-chat screen dispatched
UpdateProcessingState()in the same block asUserResolved, resetting the button to idle.CodeButtonderives its content state fromisLoading/isSuccessbut paints its background from the rawenabledflag, so the reset snapped the fill from the disabledWhite10to solidWhitein one frame while the contentCrossfadewas still ~300ms into taking the checkmark away. The result is a blank white button in the frames immediately beforenavigator.replaceopens the chat.The chat replaces this screen, so idle is a state it never shows again. Dropping the reset leaves the button holding its checkmark until the screen goes.
CashScreenViewModel, the only otherdispatchSuccessThencaller, already does it this way.