Skip to content

fix(txn-details): drop the token badge from the header avatar #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Sep 9, 2026
Merged

fix(txn-details): drop the token badge from the header avatar #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...-history/src/main/kotlin/com/flipcash/shared/transactionhistory/TransactionAvatarImage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@ private const val SwapCoinRatio = 0.625f
/**
* A [TransactionAvatar] drawn as an image: the avatar centred in a box wide enough for the token
* badge to overhang its bottom-right corner without pushing whatever sits beside it (Figma
* 9717:14138). Every caller reserves the full slot, badge or not, so a list of them lines up.
* 9717:14138). Every badged caller reserves the full slot, carrying one or not, so a list of them
* lines up.
*
* [showBadge] turns the badge off for a caller that already names the token in its own right — see
* the details screen's header (Figma 9708:117414), where it would only repeat the line under the
* amount. The slot collapses to [size] with it, since there is then nothing to overhang.
*
* Shared between the activity row and the details screen it opens, at different sizes, so the
* screen opens on exactly the avatar that was tapped rather than a second rendering of it.
Expand All @@ -47,10 +52,11 @@ fun TransactionAvatarImage(
size: Dp = CodeTheme.dimens.staticGrid.x8,
slotSize: Dp = CodeTheme.dimens.staticGrid.x10,
badgeSize: Dp = CodeTheme.dimens.staticGrid.x4,
showBadge: Boolean = true,
iconOverride: @Composable ((Any?) -> Any?) = { it },
) {
Box(
modifier = modifier.requiredSize(slotSize),
modifier = modifier.requiredSize(if (showBadge) slotSize else size),
contentAlignment = Alignment.Center,
) {
val avatarModifier = Modifier
Expand Down Expand Up @@ -85,7 +91,7 @@ fun TransactionAvatarImage(

// Ringed in the page background so the coin reads as sitting over the avatar rather than
// being part of it — the same treatment [SwapAvatar] gives its overlapping pair.
avatar.badgeToken?.let { token ->
avatar.badgeToken?.takeIf { showBadge }?.let { token ->
TokenIcon(
token = token,
iconOverride = iconOverride,
Expand Down
3 changes: 1 addition & 2 deletions ...story/src/main/kotlin/com/flipcash/shared/transactionhistory/TransactionDetailsContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,7 @@ private fun Header(
TransactionAvatarImage(
avatar = details.avatar,
size = CodeTheme.dimens.staticGrid.x16,
slotSize = CodeTheme.dimens.staticGrid.x18,
badgeSize = CodeTheme.dimens.staticGrid.x6,
showBadge = false,
iconOverride = iconOverride,
)

Expand Down
Loading