Repository navigation
refactor(activity): simplify transaction row titles - #1221
Merged
Merged
Conversation
Walk back the client-side title embellishments for buy/sell/deposit rows: Purchased, Sold and Added now render the server text verbatim instead of appending the token name or overriding USDF buys to "Added Money". Received tips read "Tip from <name>"; the label lives in strings.xml (title_activity_tipFrom) and is resolved through an injected ResourceHelper rather than a hardcoded literal.
github-actions
Bot
added
the
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Moneyoverride for USDF buys.strings.xmlastitle_activity_tipFromand is resolved through an injectedResourceHelperinstead of a hardcoded literal.TransactionItemMappergains aResourceHelperconstructor dependency (Hilt-provided). Only the placeholder ({0}) and counterparty-append paths for tips/sends remain.Test Plan
:apps:flipcash:shared:transaction-history:testDebugUnitTestpasses (title tests updated to assert verbatim buy/sell text and "Tip from …").