Repository navigation
chore(vectors): land cross-platform parity gate on code/cash - #1200
Merged
Merged
Conversation
Add the 6 remaining vector suites (ed25519, base58, slip10, solana_message, compact_message, plus currency-math which was already present) to the main branch, and establish the canonical fixture home inside this repo. Changes: - test-vectors/: canonical fixtures (7 *.json) + generators (7 gen_*.py) + README; this is the version-controlled source of truth for both apps. All per-module copies are byte-identical to canonical (sha256 verified). - libs/encryption/base58: add Base58VectorTest (host JVM) + fixture - libs/encryption/ed25519: add Ed25519VectorTest (instrumented) + fixture - libs/encryption/mnemonic: add Slip10DerivationVectorTest (instrumented) + fixture - services/opencode: add SolanaMessageVectorTest + CompactMessageVectorTest (host JVM) + fixtures - settings.gradle.kts: extend unitTestPaths to include :libs so the base58 host-JVM gate (and any future lib tests) run via flipcashTestDebug in CI - .github/workflows/ci.yml: document the TODO for instrumented-test emulator support (ed25519, mnemonic, currency-math require connectedAndroidTest) Host-JVM suites executed and green: base58, solana_message, compact_message. Instrumented suites compile-checked: ed25519, mnemonic, currency-math.
github-actions
Bot
added
type: chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-vectors/as the version-controlled canonical home for the 7 cross-platform JSON fixtures (inside this repo, as Android is the designated KMP owner); all 7 generator scripts and the README are included.chore/kmp-beachhead(ed25519, base58, slip10, solana_message, compact_message) on top of currentcode/cashvia selectivegit checkout— kmp/shared-core module scaffolding was excluded, keeping this PR focused.unitTestPathsinsettings.gradle.ktsto include:libsso the base58 host-JVM gate runs automatically viaflipcashTestDebugin CI.ci.ymlwith the exactreactivecircus/android-emulator-runnerrecipe needed when emulator support is added.SHA-256 parity (canonical vs per-module copies — all match)
9c36bf6b…95669442…dd6f9aee…d0746219…b0f2ac09…5887320f…d3683b42…Test results
base58:libs:encryption:base58:testDebugUnitTestsolana_message:services:opencode:testDebugUnitTestcompact_message:services:opencode:testDebugUnitTested25519:libs:encryption:ed25519slip10:libs:encryption:mnemoniccurrency-math:libs:currency-mathCI wiring
:libstounitTestPathsmeans:libs:encryption:base58now runs underflipcashTestDebug→ picked up by the existingci.ymlflipcash-testsjob on every PR.ci.ymlnow contains a fully-specified comment block with thereactivecircus/android-emulator-runner@v2recipe for a futurevector-instrumented-testsjob. Not wired yet — the CI only has Ubuntu runners with no emulator support.Test plan
./gradlew :libs:encryption:base58:testDebugUnitTest— BUILD SUCCESSFUL./gradlew :services:opencode:testDebugUnitTest --tests "*.SolanaMessageVectorTest" --tests "*.CompactMessageVectorTest"— BUILD SUCCESSFUL./gradlew :libs:encryption:ed25519:compileDebugAndroidTestKotlin :libs:encryption:mnemonic:compileDebugAndroidTestKotlin :libs:currency-math:compileDebugAndroidTestKotlin— BUILD SUCCESSFUL