Repository navigation
fix: DAST permissions say admins or organization managers - #2829
Merged
Merged
Conversation
The DAST API example said Git provider admin only in three places, contradicting its own intro and the code. The app-scanning note said DAST findings are visible to admins only; organization managers see them too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Overall readability score: 54.64 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
Contributor
Up to standards ✅🟢 Issues
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
✅ No blocking issues noticed
No blocking findings were identified.
Test suggestions
- Verify the API target creation and scan-trigger instructions describe both supported permission paths.
- Verify the findings visibility note describes unrestricted manager/admin access and repository-following restrictions for other members.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the API target creation and scan-trigger instructions describe both supported permission paths.
2. Verify the findings visibility note describes unrestricted manager/admin access and repository-following restrictions for other members.
TIP Add a Jira or Linear ticket key to the branch or title so the reviewer can check the PR against it. Using another tracker? Tell us.
TIP How was this review? Give us feedback
srm-service filters member results with repository_id = ANY(...), so findings from targets with no linked repository never reach members. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lventura-codacy
approved these changes
Nov 16, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer asked whether their QAs need Git provider admin rights to run DAST scans. They don't: the Codacy organization manager role is enough. Two pages gave the wrong answer.
Changes
docs/codacy-api/examples/triggering-dast-scans.md(lines 77, 107, 108)"You must have admin permissions over the organization on the Git provider" → "You must be an admin of the organization on the Git provider or an organization manager on Codacy." Now matches line 12 of the same page and line 197 of
app-scanning.md.Checked against codacy-website @19dc8e6da1:
ActiveAnalysisServicesImpl.createDastTargetandenqueueDastAnalysisboth requireOrganization × Write.RoleResolver.fetchRolemaps a Git provider member with SRM permission toUserRole.Manager. Also codacy-spa @6ad31f200:SecurityAndRiskAppScanningPage.tsx:35allows target creation formembership === 'admin' || membership === 'manager'.docs/security/app-scanning.md(line 218)"Currently, DAST findings are only visible to admin and organization admin roles" → "Only admins and organization managers can create targets and see all DAST findings. Other members only see findings from targets linked to a repository they follow," with a link to the roles page.
Checked against codacy-website @19dc8e6da1:
SrmServicesImpl.listSecurityItemsandgetSecurityDashboardscope results throughReposAndMembership.get, which leaves the filter unrestricted forManager | Adminand narrows it to followed repositories forMember. No DAST-specific role check exists.And srm-service @d6d3555f0: a DAST target's
repositoryIdis copied to its findings (DastTarget.scala:21), and the member filter is applied asrepository_id = ANY(...)(shared-domain-sql/.../sql.scala:29), which never matches aNULL. So findings from a target with no linked repository are never shown to members. I'm inferring that the items search uses this shared helper, as the other srm-service queries do; I didn't trace that exact call.Checks
mkdocs build --strict: passed.🤖 Generated with Claude Code