Skip to content

fix: DAST permissions say admins or organization managers - #2829

Merged
claudiacodacy merged 2 commits into
masterfrom
docs-fix-dast-permissions
Nov 16, 2026
Merged

claudiacodacy merged 2 commits into
masterfrom
docs-fix-dast-permissions

Conversation

@claudiacodacy

@claudiacodacy claudiacodacy commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

A customer asked whether their QAs need Git provider admin rights to run DAST scans. They don't: the Codacy organization manager role is enough. Two pages gave the wrong answer.

Changes

docs/codacy-api/examples/triggering-dast-scans.md (lines 77, 107, 108)
"You must have admin permissions over the organization on the Git provider" → "You must be an admin of the organization on the Git provider or an organization manager on Codacy." Now matches line 12 of the same page and line 197 of app-scanning.md.

Checked against codacy-website @19dc8e6da1: ActiveAnalysisServicesImpl.createDastTarget and enqueueDastAnalysis both require Organization × Write. RoleResolver.fetchRole maps a Git provider member with SRM permission to UserRole.Manager. Also codacy-spa @6ad31f200: SecurityAndRiskAppScanningPage.tsx:35 allows target creation for membership === 'admin' || membership === 'manager'.

docs/security/app-scanning.md (line 218)
"Currently, DAST findings are only visible to admin and organization admin roles" → "Only admins and organization managers can create targets and see all DAST findings. Other members only see findings from targets linked to a repository they follow," with a link to the roles page.

Checked against codacy-website @19dc8e6da1: SrmServicesImpl.listSecurityItems and getSecurityDashboard scope results through ReposAndMembership.get, which leaves the filter unrestricted for Manager | Admin and narrows it to followed repositories for Member. No DAST-specific role check exists.

And srm-service @d6d3555f0: a DAST target's repositoryId is copied to its findings (DastTarget.scala:21), and the member filter is applied as repository_id = ANY(...) (shared-domain-sql/.../sql.scala:29), which never matches a NULL. So findings from a target with no linked repository are never shown to members. I'm inferring that the items search uses this shared helper, as the other srm-service queries do; I didn't trace that exact call.

Checks

  • mkdocs build --strict: passed.
  • Vale on both files: no alerts on the changed lines.
  • No headings, anchors, includes or lockstep siblings touched.

🤖 Generated with Claude Code

The DAST API example said Git provider admin only in three places,
contradicting its own intro and the code. The app-scanning note said
DAST findings are visible to admins only; organization managers see
them too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claudiacodacy
claudiacodacy requested a review from a team as a code owner November 16, 2026 12:48
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Overall readability score: 54.64 (🟢 +0)

File Readability
app-scanning.md 75.76 (🟢 +0.09)
triggering-dast-scans.md 65.91 (🟢 +0.54)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
app-scanning.md 75.76 57.27 7.68 9.2 10.08 6.11
  🟢 +0.09 🟢 +0 🟢 +0.04 🟢 +0 🔴 -0.05 🟢 +0.03
triggering-dast-scans.md 65.91 47.59 9.32 10.6 10.9 6.81
  🟢 +0.54 🔴 -0.4 🔴 -0.03 🟢 +0.1 🟢 +0.23 🟢 +0.06

Averages:

  Readability FRE GF ARI CLI DCRS
Average 54.64 43.05 10.78 12.26 12.3 7.94
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

✅ No blocking issues noticed

No blocking findings were identified.

Test suggestions

  • Verify the API target creation and scan-trigger instructions describe both supported permission paths.
  • Verify the findings visibility note describes unrestricted manager/admin access and repository-following restrictions for other members.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the API target creation and scan-trigger instructions describe both supported permission paths.
2. Verify the findings visibility note describes unrestricted manager/admin access and repository-following restrictions for other members.

TIP Add a Jira or Linear ticket key to the branch or title so the reviewer can check the PR against it. Using another tracker? Tell us.
TIP How was this review? Give us feedback

@github-actions
github-actions Bot temporarily deployed to Netlify November 16, 2026 12:50 Inactive
srm-service filters member results with repository_id = ANY(...), so
findings from targets with no linked repository never reach members.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions
github-actions Bot temporarily deployed to Netlify November 16, 2026 12:56 Inactive
@claudiacodacy
claudiacodacy merged commit 71fb5c7 into master Nov 16, 2026
5 checks passed
@claudiacodacy
claudiacodacy deleted the docs-fix-dast-permissions branch November 16, 2026 14:39

This branch was previously deployed

1 inactive deployment
Netlify — 52b7a931 Deployed Nov 16, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants