fix: product deletion survives restart (one-time seed marker)#4
Merged
Annotations
10 warnings
|
Build backend:
src/Cocoar.Shelf/Identity/MartenUserStore.cs#L25
In member Task<IdentityResult> MartenUserStore.CreateAsync(UserDocument user, CancellationToken ct), change parameter name ct to cancellationToken in order to match the identifier as it has been declared in Task<IdentityResult> IUserStore<UserDocument>.CreateAsync(UserDocument user, CancellationToken cancellationToken) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
Build backend:
src/Cocoar.Shelf/Endpoints/GroupEndpoints.cs#L174
Change return type of method 'NormalizeEmails' from 'System.Collections.Generic.IReadOnlyList<string>' to 'System.Collections.Generic.List<string>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
Build backend:
src/Cocoar.Shelf/Endpoints/GroupEndpoints.cs#L135
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'GroupEndpoints.TestScript(GroupScriptTestRequest, IGroupMembershipEvaluator, IDocumentStore)' with a call to 'string.ToLower(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
|
|
Build backend:
src/Cocoar.Shelf/Endpoints/GroupEndpoints.cs#L135
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'GroupEndpoints.TestScript(GroupScriptTestRequest, IGroupMembershipEvaluator, IDocumentStore)' with a call to 'string.ToLower(CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
|
|
Build backend:
src/Cocoar.Shelf/Endpoints/GroupEndpoints.cs#L134
Do not use Enumerable methods on indexable collections. Instead use the collection directly. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1826)
|
|
Build backend:
src/Cocoar.Shelf/Endpoints/GroupEndpoints.cs#L135
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
|
Build backend:
src/Cocoar.Shelf/Endpoints/GroupEndpoints.cs#L135
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
|
|
Build backend:
src/Cocoar.Shelf/Endpoints/GroupEndpoints.cs#L135
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
|
|
Build backend:
src/Cocoar.Shelf/Endpoints/TestAuthEndpoints.cs#L49
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
|
|
Build backend:
src/Cocoar.Shelf/Program.cs#L68
Possible null reference return.
|
background
wait
wait-all
cancel
parallel
Loading