Repository navigation
Pin Queue L0 retry detection to Midge and count admission pressure - #467
Merged
Merged
Conversation
Queue ENQUEUE/ACK retries match Midge's "column family {id} has no free
L0 slot (" WriteStall message. Midge exposes no structured variant or
constant for it, and the existing tests built the string by hand, so a
Midge rewording would silently disable the retry.
Add a test that opens Midge with background compaction disabled, fills
the family's L0 slots, and checks the real rejection against the Queue
classifier. Add production counters for L0 admission restages and for
commits that fail after the shared 30-second admission budget runs out,
export them from the admin metrics endpoint, and document them.
smiggleworth
commented
Oct 10, 2026
smiggleworth
left a comment
Contributor
Author
There was a problem hiding this comment.
Adversarial source review of 957871d. Reviewed real Midge rejection reproduction, exact family match, terminal errors and descriptive admission counters. All 120 Queue actor tests passed, including a real Midge L0 rejection. Integration with the latest develop and fresh hosted checks remain required before merge.
…ep-queue467-20261011
…ep-queue467-20261011
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue ENQUEUE/ACK retries remain limited to the pinned Midge pre-WAL L0 admission rejection. A real engine regression binds the family-specific error-text classifier to Midge d5bcb607. Unrelated, unknown and post-WAL errors remain terminal.
Production counters record each restaged L0 retry and one terminal admission-budget failure. A typed admission_stalled flag distinguishes real pre-commit stall timeout without another error-text match. Metrics exports and Queue operations documentation agree.
Global counter assertions run in bounded exact-test child processes with a completion receipt and timeout cleanup. Coverage includes retry success, bounded ACK exhaustion with unchanged stored state, zero-duration exhaustion, real admission timeout and unrelated terminal errors.
Validation history at d5831a3
Refreshed candidate 08c2eb6
AI assistance: Codex refined isolated metric regressions, adversarially reviewed the patch and corrected the architecture integration.
Fixes #438