fix: RegisterService should return errors instead of panic - #1982
Closed
lxcxjxhx wants to merge 1 commit into
Closed
fix: RegisterService should return errors instead of panic#1982lxcxjxhx wants to merge 1 commit into
lxcxjxhx wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The RegisterService method declares error in its return signature but uses panic() for parameter validation. This violates Go error handling best practices and can cause unexpected crashes for callers who expect to handle errors gracefully.
Fixes #1981
Changes
Replace panic() calls with return errors.New() in RegisterService method:
Testing
Note: Local environment limitations, relying on CI/CD automated testing.