Skip to content

fix(remote): treat encode failure on closed conn as remote-closed in … - #1978

Merged
junliurs merged 1 commit into
cloudwego:mainfrom
junliurs:fix/server-onerror-detect-remote-closed-by-conn-state
Jul 28, 2026
Merged

fix(remote): treat encode failure on closed conn as remote-closed in …#1978
junliurs merged 1 commit into
cloudwego:mainfrom
junliurs:fix/server-onerror-detect-remote-closed-by-conn-state

Conversation

@junliurs

Copy link
Copy Markdown
Contributor

…OnError

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@junliurs
junliurs requested review from a team as code owners July 22, 2026 03:45
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.08%. Comparing base (8bb270e) to head (0f23cef).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/remote/trans/common.go 73.91% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1978      +/-   ##
==========================================
+ Coverage   62.95%   63.08%   +0.12%     
==========================================
  Files         394      396       +2     
  Lines       30267    30347      +80     
==========================================
+ Hits        19056    19144      +88     
+ Misses       9924     9919       -5     
+ Partials     1287     1284       -3     
Flag Coverage Δ
integration 51.97% <68.33%> (+0.09%) ⬆️
unit 53.69% <90.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@junliurs
junliurs force-pushed the fix/server-onerror-detect-remote-closed-by-conn-state branch 3 times, most recently from d7a928c to 8647201 Compare July 24, 2026 03:37
@junliurs
junliurs force-pushed the fix/server-onerror-detect-remote-closed-by-conn-state branch from 4d65169 to 0f23cef Compare July 24, 2026 09:50

@wdp2020 wdp2020 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Comment thread pkg/remote/trans/netpollmux/server_handler.go Outdated
@junliurs
junliurs merged commit 099b60a into cloudwego:main Jul 28, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants