Skip to content

feat: Table Column Groups Collection Prefs#4487

Open
NathanZlion wants to merge 12 commits into
mainfrom
dev-v3-natidere-collection-prefs
Open

feat: Table Column Groups Collection Prefs#4487
NathanZlion wants to merge 12 commits into
mainfrom
dev-v3-natidere-collection-prefs

Conversation

@NathanZlion
Copy link
Copy Markdown
Member

@NathanZlion NathanZlion commented May 4, 2026

Description

Add Table Column Grouping Feature support in collection preferences.

Related links, issue AWSUI-9594, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NathanZlion NathanZlion changed the title feat: Add collection preferences for grouped items feat: Table Groups Collection Pres May 4, 2026
@NathanZlion NathanZlion changed the title feat: Table Groups Collection Pres feat: Table Column Groups Collection Pres May 4, 2026
@NathanZlion NathanZlion changed the title feat: Table Column Groups Collection Pres feat: Table Column Groups Collection Prefs May 4, 2026
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-collection-prefs branch from aef643e to d30a4c0 Compare May 4, 2026 15:59
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-collection-prefs branch from 3eb8ca8 to ba91764 Compare May 5, 2026 14:25
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-collection-prefs branch from ba91764 to 8e47ee3 Compare May 5, 2026 14:49
@NathanZlion NathanZlion force-pushed the dev-v3-natidere-collection-prefs branch from 652c9fc to 2b8739b Compare May 5, 2026 18:00
@NathanZlion NathanZlion marked this pull request as ready for review May 6, 2026 08:36
@NathanZlion NathanZlion requested a review from a team as a code owner May 6, 2026 08:36
@NathanZlion NathanZlion requested review from jperals and removed request for a team May 6, 2026 08:36
Comment thread src/collection-preferences/content-display/__tests__/content-display.test.tsx Outdated
Comment thread src/collection-preferences/content-display/__tests__/content-display.test.tsx Outdated
Comment thread src/collection-preferences/content-display/index.tsx Outdated
Comment thread src/collection-preferences/content-display/index.tsx Outdated
i18nStrings={i18nStrings}
onSortingChange={
// istanbul ignore next: requires DnD interaction
({ detail: { items } }) => onTreeChange([...items])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can actually test this event same way as in src/file-dropzone/__tests__/file-dropzone.test.tsx

id: node.id,
announcementLabel:
node.type === 'group'
? `${node.label}, ${node.children.length} items`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it come from i18n strings?

Comment thread src/collection-preferences/utils.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants