feat: Table Column Groups Collection Prefs#4487
Open
NathanZlion wants to merge 12 commits into
Open
Conversation
aef643e to
d30a4c0
Compare
3eb8ca8 to
ba91764
Compare
ba91764 to
8e47ee3
Compare
652c9fc to
2b8739b
Compare
georgylobko
reviewed
May 12, 2026
| i18nStrings={i18nStrings} | ||
| onSortingChange={ | ||
| // istanbul ignore next: requires DnD interaction | ||
| ({ detail: { items } }) => onTreeChange([...items]) |
Member
There was a problem hiding this comment.
you can actually test this event same way as in src/file-dropzone/__tests__/file-dropzone.test.tsx
| id: node.id, | ||
| announcementLabel: | ||
| node.type === 'group' | ||
| ? `${node.label}, ${node.children.length} items` |
Member
There was a problem hiding this comment.
should it come from i18n strings?
2e0a3c7 to
77ee68a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Table Column Grouping Feature support in collection preferences.
Related links, issue AWSUI-9594, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.