Repository navigation
Fix pickling contextlib-decorated functions - #620
Open
jipeng6036-del wants to merge 1 commit into
Open
jipeng6036-del wants to merge 1 commit into
jipeng6036-del wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #509.
Functions decorated with
contextlib.contextmanagerorasynccontextmanagerretain an unused generator in the decorator closure, which currently prevents by-value serialization. I added reducers that recreate an unused context manager from its native generator factory and arguments, preserving custom state and shared references.The reducers reject generators that have started or closed and factories whose calls could run construction side effects. Context managers backed by already-pickleable ordinary iterators keep their existing object reduction and iterator position. Ordinary generators remain unsupported.
Validation:
--all-filesrun finds the same Black formatting difference in the unmodified ipykernel test file on both baseline and candidate. Subprocess coverage setup, combination, and XML generation were exercised. macOS and the remaining OS/version combinations are left to upstream CI.Raw verification results.