Skip to content

feat(supernova): add perses presentation plusone presentation#1683

Draft
ibakshay wants to merge 5 commits into
mainfrom
ibakshay/perses-alert-in-supernova
Draft

feat(supernova): add perses presentation plusone presentation#1683
ibakshay wants to merge 5 commits into
mainfrom
ibakshay/perses-alert-in-supernova

Conversation

@ibakshay
Copy link
Copy Markdown

@ibakshay ibakshay commented May 11, 2026

Summary

  • Adds regional Perses dashboard link (persesDashboard label) and global Perses dashboard link (persesGlobalDashboard label) to the AlertLinks component
  • Links are rendered before the existing Plutono link.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Copilot AI review requested due to automatic review settings May 11, 2026 12:33
@ibakshay ibakshay requested a review from a team as a code owner May 11, 2026 12:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

🦋 Changeset detected

Latest commit: 59296a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudoperators/juno-app-supernova Minor
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in Supernova’s alert details UI to surface Perses dashboard links derived from alert labels, alongside the existing set of quick links.

Changes:

  • Render a regional Perses dashboard link when labels.persesDashboard and labels.region are present.
  • Render a global Perses dashboard link when labels.persesGlobalDashboard is present.
  • Place the new links before the existing Plutono dashboard link in the AlertLinks list.

Comment thread apps/supernova/src/components/alerts/shared/AlertLinks.tsx
Comment thread apps/supernova/src/components/alerts/shared/AlertLinks.tsx
Comment thread apps/supernova/src/components/alerts/shared/AlertLinks.tsx Outdated
Comment thread apps/supernova/src/components/alerts/shared/AlertLinks.tsx
ibakshay added 2 commits May 11, 2026 14:38
Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
@ibakshay ibakshay force-pushed the ibakshay/perses-alert-in-supernova branch from 8a52da5 to fe599fc Compare May 11, 2026 12:38
@ibakshay ibakshay changed the title add perses presentation plusone presentation feat(supernova): add perses presentation plusone presentation May 11, 2026
Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
@ArtieReus
Copy link
Copy Markdown
Collaborator

Hi @ibakshay! Thank you for the PR. Looks good from the implementation perspective. But all those links have to move away. We need to map those links differently then hardcoding them.

@ibakshay
Copy link
Copy Markdown
Author

Hi @ibakshay! Thank you for the PR. Looks good from the implementation perspective. But all those links have to move away. We need to map those links differently then hardcoding them.

Thank you for the review!
I only followed how it is done for the existing links. All the existing links are hard-coded as well.
For example

href={`https://logs.${alert?.labels?.region}.cloud.sap/${alert?.labels?.kibana}`}

Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ArtieReus ArtieReus added greenhouse Greenhouse core related task supernova All tasks related to supernova labels May 12, 2026
@ArtieReus
Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus added the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label May 12, 2026
@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label May 12, 2026
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels May 12, 2026
@ArtieReus ArtieReus added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels May 13, 2026
@ArtieReus
Copy link
Copy Markdown
Collaborator

Setting it to draft to have it as a base for a discussion

@ArtieReus ArtieReus marked this pull request as draft May 13, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenhouse Greenhouse core related task greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. supernova All tasks related to supernova

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants