feat(supernova): add perses presentation plusone presentation#1683
feat(supernova): add perses presentation plusone presentation#1683ibakshay wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: 59296a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Adds support in Supernova’s alert details UI to surface Perses dashboard links derived from alert labels, alongside the existing set of quick links.
Changes:
- Render a regional Perses dashboard link when
labels.persesDashboardandlabels.regionare present. - Render a global Perses dashboard link when
labels.persesGlobalDashboardis present. - Place the new links before the existing Plutono dashboard link in the
AlertLinkslist.
Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
8a52da5 to
fe599fc
Compare
Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
|
Hi @ibakshay! Thank you for the PR. Looks good from the implementation perspective. But all those links have to move away. We need to map those links differently then hardcoding them. |
Thank you for the review! |
|
Discussion started here: |
|
Setting it to draft to have it as a base for a discussion |
Summary
Checklist
PR Manifesto
Review the PR Manifesto for best practises.