Conversation
Closes #840 The e2e kustomize overlay matches docker.io/library/plugin-barman-cloud but the base kustomization at kubernetes/kustomization.yaml matches the bare plugin-barman-cloud name from kubernetes/deployment.yaml and replaces it with the GHCR image. Since the overlay name never matches, the locally-built image is never deployed and e2e tests always run against the main branch code from GHCR. Use the bare image name so the overlay rule overrides the base rule. Broken since b7daaac (#89) changed the base kustomization's newName from docker.io/library/plugin-barman-cloud to the GHCR image without updating the e2e overlay. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
dosubot
bot
added
size:XS
mnencia
force-pushed
the
dev/840
branch
2 times, most recently
from
e30615d to
bdc76c1
Compare
The e2e kustomize overlay tried to match docker.io/library/plugin-barman-cloud but the base kustomization at kubernetes/kustomization.yaml already transforms the bare plugin-barman-cloud image to the GHCR name. The overlay must match the base's output (ghcr.io/cloudnative-pg/plugin-barman-cloud-testing) to override it. Add comments on both sides to prevent future drift. Broken since b7daaac (#89) changed the base kustomization's newName from docker.io/library/plugin-barman-cloud to the GHCR image without updating the e2e overlay. Closes #840 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
changed the title
armru
approved these changes
Apr 11, 2026
gbartolini
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e kustomize overlay tried to match
docker.io/library/plugin-barman-cloudbut the base kustomization atkubernetes/kustomization.yamlalready transforms the bareplugin-barman-cloudimage to the GHCR name. The overlay must matchthe base's output (
ghcr.io/cloudnative-pg/plugin-barman-cloud-testing)to override it.
Broken since b7daaac (#89) changed the base kustomization's newName
from
docker.io/library/plugin-barman-cloudto the GHCR image withoutupdating the e2e overlay.
Closes #840