Skip to content

fix(s3/integration): wait for bucket visibility after ensure-storage-… #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanme merged 1 commit into from
Sep 9, 2026
Merged

fix(s3/integration): wait for bucket visibility after ensure-storage-… #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions s3/integration/assertions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,14 @@ func AssertOnStorageExists(s3CLIPath string, cfg *config.S3Cli) {
Expect(s3CLISession.ExitCode()).To(BeZero())

// Verify the bucket now exists using the client created earlier.
_, headBucketErr := verificationClient.HeadBucket(context.TODO(), &s3.HeadBucketInput{
// Use a waiter rather than a bare HeadBucket call: in slower/newer regions (e.g. eusc-de-east-1)
// bucket creation may not yet be visible from a fresh client connection even after the CLI's
// own BucketExistsWaiter returned success.
bucketWaiter := s3.NewBucketExistsWaiter(verificationClient)
waitErr := bucketWaiter.Wait(context.TODO(), &s3.HeadBucketInput{
Bucket: aws.String(cfgCopy.BucketName),
})
Expect(headBucketErr).ToNot(HaveOccurred(), "Bucket should have been created by 'ensure-storage-exists'")
}, 60*time.Second)
Expect(waitErr).ToNot(HaveOccurred(), "Bucket should have been created by 'ensure-storage-exists'")

// --- Scenario 2: Bucket already exists, command should still succeed (idempotency) ---
s3CLISession, err = RunS3CLI(s3CLIPath, configPath, "s3", "ensure-storage-exists")
Expand Down