fix(switchboard): pin tedsuo/ifrit to pre-regression commit - #131
Merged
Conversation
A dependency bump (bdfde52) pulled in a tedsuo/ifrit commit whose http_server.Run() calls log.Fatalf (hard os.Exit(1)) whenever server.Shutdown() returns a non-ErrServerClosed error - which it reliably does, since the same code path closes the listener manually right before calling Shutdown(). Inside a Ginkgo parallel worker this hard-exits the process before it can report back to the CLI, producing "Ginkgo timed out waiting for all parallel procs to report back" in runner/http (and intermittently bridge/health). Pin ifrit via a `replace` directive (not a plain require) to the last known-good commit, since ifrit has no tagged releases and the repo's automated dependency bumps may otherwise silently re-introduce the buggy commit on its next run. Also cap switchboard's `bin/test` ginkgo -p worker count to min(nproc, 4); unbounded parallelism made the crash more likely to manifest under load, though it wasn't the root cause.
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
kimago
approved these changes
Aug 20, 2026
kimago
left a comment
kimago
left a comment
Member
There was a problem hiding this comment.
Topline pins are clear, I trust go.mod with dependencies.
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dependency bump (bdfde52) pulled in a tedsuo/ifrit commit whose http_server.Run() calls log.Fatalf (hard os.Exit(1)) whenever server.Shutdown() returns a non-ErrServerClosed error - which it reliably does, since the same code path closes the listener manually right before calling Shutdown(). Inside a Ginkgo parallel worker this hard-exits the process before it can report back to the CLI, producing "Ginkgo timed out waiting for all parallel procs to report back" in runner/http (and intermittently bridge/health).
Pin ifrit via a
replacedirective (not a plain require) to the last known-good commit, since ifrit has no tagged releases and the repo's automated dependency bumps may otherwise silently re-introduce the buggy commit on its next run.Also cap switchboard's
bin/testginkgo -p worker count to min(nproc, 4); unbounded parallelism made the crash more likely to manifest under load, though it wasn't the root cause.