Refresh test dependencies to unblock dependency bumps by Alphasite · Pull Request #95 · cloudfoundry/gosigar

Alphasite · 2026-10-29T20:41:52Z

The bump-deps job fails when go get -u -t all expands the existing dependency graph and tries to resolve golang.org/x/tools/internal/aliases in x/tools v0.52.0, where that package has been removed.

Refresh the test dependencies with go get -u -t ./..., run go mod tidy, and regenerate vendor. This updates x/tools from v0.44.0 to v0.52.0 and removes the stale package dependency so the full dependency upgrade can proceed.

Most of the deletions are vendored dependency cleanup: 11,498 of the 15,761 deleted lines (73%) remove gopkg.in/yaml.v3, because Testify now uses go.yaml.in/yaml/v3, which Gomega already used. Another 2,638 deletions come from the x/tools upgrade, including older helper packages such as internal/aliases. No gosigar implementation or test files were removed.

Validation:

Reproduced the original failure and confirmed go get -u -t all succeeds after the test dependency refresh in a temporary checkout.
go test -race ./... passed on macOS.
Linux and Windows amd64 tests compiled successfully using CGO_ENABLED=0 go test -exec=/usr/bin/true ./... with the respective GOOS values; these were compilation checks only.
The staged whitespace check passed except for the upstream ======= Markdown heading in Testify's vendored internal/spew/README.md; that file matches the downloaded module exactly.

Copilot

🔵 Needs a closer look

The shared visited set incorrectly treats repeated pointers in acyclic data as cycles, hiding values in assertion failure messages.

No open issues 🎉

What changed in this PR

Refreshes gosigar’s test dependencies and vendored sources to remove the obsolete x/tools/internal/aliases dependency blocking bump-deps, including upgrading x/tools from v0.44.0 to v0.52.0.

Changes:

Updates Ginkgo, Gomega, Testify, and related indirect dependencies.
Removes obsolete vendored packages and compatibility helpers.
Synchronizes module requirements and vendor contents with upstream updates.

This pull request requires changes.

One unresolved moderate issue remains in vendor/github.com/onsi/gomega/format/format.go:374: pointer tracking persists across sibling values, incorrectly labeling repeated pointers in acyclic data as cyclic references and hiding assertion diagnostics. Remove each pointer from the visited set when its recursive formatting call returns so only the active recursion path counts as a cycle.

File	Description
`vendor/modules.txt`	Synchronizes vendored versions and package inventory.
`vendor/gopkg.in/yaml.v3/writerc.go`	Removes obsolete YAML writer implementation.
`vendor/gopkg.in/yaml.v3/sorter.go`	Removes obsolete YAML key sorting.
`vendor/gopkg.in/yaml.v3/README.md`	Removes obsolete package documentation.
`vendor/gopkg.in/yaml.v3/NOTICE`	Removes obsolete package notice.
`vendor/gopkg.in/yaml.v3/LICENSE`	Removes obsolete package license.
`vendor/golang.org/x/tools/internal/typesinternal/zerovalue.go`	Updates type-expression generation.
`vendor/golang.org/x/tools/internal/typesinternal/varkind.go`	Removes variable-kind compatibility aliases.
`vendor/golang.org/x/tools/internal/typesinternal/varkind_go124.go`	Removes older Go compatibility helpers.
`vendor/golang.org/x/tools/internal/typesinternal/types.go`	Updates type helpers and field-selection traversal.
`vendor/golang.org/x/tools/internal/typesinternal/toonew.go`	Refines standard-library symbol availability checks.
`vendor/golang.org/x/tools/internal/typesinternal/recv.go`	Replaces receiver-type lookup helper.
`vendor/golang.org/x/tools/internal/typesinternal/isnamed.go`	Uses the updated receiver helper.
`vendor/golang.org/x/tools/internal/typesinternal/element.go`	Revises reachable-type traversal and deduplication.
`vendor/golang.org/x/tools/internal/typesinternal/classify_call.go`	Replaces linkname-based call helpers.
`vendor/golang.org/x/tools/internal/typesinternal/assignedaddress.go`	Adds assignment and address-taking analysis.
`vendor/golang.org/x/tools/internal/typeparams/typeterm.go`	Removes obsolete type-term implementation.
`vendor/golang.org/x/tools/internal/typeparams/termlist.go`	Removes obsolete term-list implementation.
`vendor/golang.org/x/tools/internal/typeparams/free.go`	Removes unused type-parameter analysis.
`vendor/golang.org/x/tools/internal/typeparams/coretype.go`	Removes obsolete core-type helpers.
`vendor/golang.org/x/tools/internal/typeparams/common.go`	Removes unused generic syntax helpers.
`vendor/golang.org/x/tools/internal/pkgbits/version.go`	Adds method-order-preserving export format support.
`vendor/golang.org/x/tools/internal/pkgbits/sync.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/pkgbits/support.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/pkgbits/reloc.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/pkgbits/encoder.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/pkgbits/doc.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/pkgbits/decoder.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/pkgbits/codes.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/moremaps/maps.go`	Adds shared map utilities.
`vendor/golang.org/x/tools/internal/gocommand/version.go`	Simplifies reverse version-tag iteration.
`vendor/golang.org/x/tools/internal/gocommand/invoke.go`	Updates overlays and subprocess cancellation.
`vendor/golang.org/x/tools/internal/gocommand/invoke_unix.go`	Adds Unix process-group cancellation.
`vendor/golang.org/x/tools/internal/gocommand/invoke_notunix.go`	Adds non-Unix cancellation helpers.
`vendor/golang.org/x/tools/internal/gcimporter/support.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/gcimporter/predeclared.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/gcimporter/gcimporter.go`	Supports indexed export-data imports.
`vendor/golang.org/x/tools/internal/gcimporter/exportdata.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/gcimporter/bimport.go`	Documents dependency restrictions.
`vendor/golang.org/x/tools/internal/aliases/aliases.go`	Removes obsolete alias compatibility package.
`vendor/golang.org/x/tools/go/types/typeutil/ui.go`	Removes unused method-set utility.
`vendor/golang.org/x/tools/go/types/typeutil/methodsetcache.go`	Removes unused method-set cache.
`vendor/golang.org/x/tools/go/types/typeutil/imports.go`	Removes unused dependency traversal helper.
`vendor/golang.org/x/tools/go/types/typeutil/callee.go`	Removes superseded call-analysis helpers.
`vendor/golang.org/x/tools/go/packages/visit.go`	Uses shared deterministic map iteration.
`vendor/golang.org/x/tools/go/packages/packages.go`	Improves duplicate-package and export-data errors.
`vendor/golang.org/x/tools/go/packages/golist_overlay.go`	Recognizes all main-module overlay roots.
`vendor/golang.org/x/tools/go/ast/inspector/cursor.go`	Adds cursor-path formatting.
`vendor/golang.org/x/tools/go/ast/edge/edge.go`	Updates edge access and stability documentation.
`vendor/golang.org/x/text/encoding/japanese/iso2022jp.go`	Clarifies encoding compatibility and forwarding guidance.
`vendor/golang.org/x/sync/errgroup/errgroup.go`	Clarifies channel-barging comment.
`vendor/golang.org/x/net/html/token.go`	Updates tokenization and fragment handling.
`vendor/golang.org/x/net/html/render.go`	Tightens literal-text namespace checks.
`vendor/golang.org/x/net/html/foreign.go`	Updates foreign-attribute normalization.
`vendor/golang.org/x/net/html/entity.go`	Enables two additional HTML entities.
`vendor/go.yaml.in/yaml/v3/yamlh.go`	Refreshes handler-comment formatting.
`vendor/github.com/stretchr/testify/internal/spew/README.md`	Includes internal pretty-printer documentation.
`vendor/github.com/stretchr/testify/internal/spew/LICENSE`	Includes internal pretty-printer license.
`vendor/github.com/stretchr/testify/internal/spew/dump.go`	Refreshes documentation formatting.
`vendor/github.com/stretchr/testify/internal/spew/config.go`	Refreshes configuration documentation formatting.
`vendor/github.com/stretchr/testify/internal/spew/bypasssafe.go`	Adds modern safe-mode build constraint.
`vendor/github.com/stretchr/testify/internal/spew/bypass.go`	Adds modern unsafe-mode build constraint.
`vendor/github.com/stretchr/testify/internal/difflib/LICENSE`	Normalizes license file ending.
`vendor/github.com/stretchr/testify/assert/yaml/yaml_fail.go`	Adds disabled-YAML build option.
`vendor/github.com/stretchr/testify/assert/yaml/yaml_default.go`	Adds default YAML backend adapter.
`vendor/github.com/stretchr/testify/assert/yaml/yaml_custom.go`	Adds custom YAML backend option.
`vendor/github.com/stretchr/testify/assert/http_assertions.go`	Updates request construction and assertion diagnostics.
`vendor/github.com/stretchr/testify/assert/doc.go`	Updates assertion API documentation.
`vendor/github.com/stretchr/testify/assert/assertion_order.go`	Updates ordering helpers and diagnostics.
`vendor/github.com/stretchr/testify/assert/assertion_compare_legacy.go`	Removes legacy reflection compatibility helper.
`vendor/github.com/stretchr/testify/assert/assertion_compare_can_convert.go`	Removes superseded conversion wrapper.
`vendor/github.com/onsi/gomega/types/types.go`	Documents assertion annotations.
`vendor/github.com/onsi/gomega/README.md`	Refreshes upstream documentation and badges.
`vendor/github.com/onsi/gomega/matchers/type_support.go`	Adds exact integer conversion helper.
`vendor/github.com/onsi/gomega/matchers/support/goraph/edge/edge.go`	Simplifies edge membership checks.
`vendor/github.com/onsi/gomega/matchers/match_yaml_matcher.go`	Adds multi-document YAML comparison.
`vendor/github.com/onsi/gomega/matchers/match_xml_matcher.go`	Normalizes XML namespace declarations.
`vendor/github.com/onsi/gomega/matchers/match_json_matcher.go`	Preserves precise large-integer JSON comparison.
`vendor/github.com/onsi/gomega/matchers/match_error_strictly_matcher.go`	Adds strict error matching.
`vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.go`	Prioritizes matching entries over unrelated errors.
`vendor/github.com/onsi/gomega/matchers/have_key_matcher.go`	Prioritizes matching keys over unrelated errors.
`vendor/github.com/onsi/gomega/matchers/have_exact_elements.go`	Corrects extra and missing element reporting.
`vendor/github.com/onsi/gomega/matchers/be_numerically_matcher.go`	Updates exact integer and threshold comparisons.
`vendor/github.com/onsi/gomega/matchers/be_an_array_matcher.go`	Adds array-type matcher.
`vendor/github.com/onsi/gomega/matchers/be_a_slice_matcher.go`	Adds slice-type matcher.
`vendor/github.com/onsi/gomega/matchers/attributes_slice.go`	Makes XML attribute sorting deterministic.
`vendor/github.com/onsi/gomega/matchers.go`	Exposes new matchers and updated documentation.
`vendor/github.com/onsi/gomega/gomega_dsl.go`	Updates Gomega version constant.
`vendor/github.com/onsi/gomega/format/format.go`	Adds pointer-cycle tracking and formatting updates; unresolved issue noted above.
`vendor/github.com/onsi/gomega/CHANGELOG.md`	Records upstream releases and fixes.
`vendor/github.com/onsi/gomega/.gitignore`	Ignores upstream release workspace.
`vendor/github.com/onsi/ginkgo/v2/types/version.go`	Updates Ginkgo version constant.
`vendor/github.com/onsi/ginkgo/v2/types/semver_filter.go`	Adds component-specific semantic-version filters.
`vendor/github.com/onsi/ginkgo/v2/types/flags.go`	Adds flag-completion lookup.
`vendor/github.com/onsi/ginkgo/v2/types/errors.go`	Adds configuration validation errors.
`vendor/github.com/onsi/ginkgo/v2/types/config.go`	Adds reporting, debugging, and sanitizer options.
`vendor/github.com/onsi/ginkgo/v2/reporters/teamcity_report.go`	Includes component constraints in report names.
`vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.go`	Adds report-entry properties and component constraints.
`vendor/github.com/onsi/ginkgo/v2/RELEASING.md`	Documents upstream automated release process.
`vendor/github.com/onsi/ginkgo/v2/README.md`	Refreshes upstream documentation and branding.
`vendor/github.com/onsi/ginkgo/v2/internal/testingtproxy/testing_t_proxy.go`	Reuses formatters and adds artifact directories.
`vendor/github.com/onsi/ginkgo/v2/internal/reporters/gojson.go`	Includes component constraints in JSON test names.
`vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/server_handler.go`	Tracks completed parallel workers.
`vendor/github.com/onsi/ginkgo/v2/internal/group.go`	Updates reports and repeated-spec teardown handling.
`vendor/github.com/onsi/ginkgo/v2/internal/global/init.go`	Makes suite-run tracking resettable.
`vendor/github.com/onsi/ginkgo/v2/internal/focus.go`	Applies component-specific version filters.
`vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/watch_command.go`	Reconciles documentation-output execution settings.
`vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.go`	Reconciles output settings and updates documentation link.
`vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline.go`	Expands table-subtree outline entries.
`vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/ginkgo.go`	Recognizes table-subtree DSL functions.
`vendor/github.com/onsi/ginkgo/v2/ginkgo/main.go`	Registers shell-completion command.
`vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/run.go`	Updates worker tracking and exit diagnostics.
`vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.go`	Handles diagnostic text as literal output.
`vendor/github.com/onsi/ginkgo/v2/ginkgo_t_dsl.go`	Exposes artifact-directory compatibility API.
`vendor/github.com/onsi/ginkgo/v2/decorator_dsl.go`	Adds component semantic-version decorators.
`vendor/github.com/onsi/ginkgo/v2/core_dsl.go`	Integrates component constraints and resettable suite state.
`vendor/github.com/onsi/ginkgo/v2/CHANGELOG.md`	Records upstream releases and fixes.
`vendor/github.com/onsi/ginkgo/v2/.gitignore`	Updates upstream temporary-file exclusions.
`vendor/github.com/Masterminds/semver/v3/version.go`	Adds parsing bounds, overflow checks, and scanning support.
`vendor/github.com/Masterminds/semver/v3/.golangci.yml`	Refreshes upstream linter configuration.
`vendor/github.com/Masterminds/semver/v3/.gitignore`	Ignores upstream development-container directory.
`vendor/github.com/google/pprof/profile/proto.go`	Preallocates packed protobuf value slices.
`vendor/github.com/google/pprof/profile/profile.go`	Propagates compressed-writer close errors.
`vendor/github.com/google/pprof/profile/merge.go`	Corrects location-key indexing.
`vendor/github.com/google/pprof/profile/filter.go`	Removes units alongside filtered numeric labels.
`vendor/github.com/go-logr/logr/slogsink.go`	Removes legacy build-tag syntax.
`vendor/github.com/go-logr/logr/slogr.go`	Removes legacy build-tag syntax.
`vendor/github.com/go-logr/logr/sloghandler.go`	Removes legacy build-tag syntax.
`vendor/github.com/go-logr/logr/funcr/slogsink.go`	Bounds nested slog-group conversion.
`vendor/github.com/go-logr/logr/funcr/funcr.go`	Adds pointer-recursion protection to formatting.
`vendor/github.com/go-logr/logr/context_slog.go`	Removes legacy build-tag syntax.
`vendor/github.com/go-logr/logr/context_noslog.go`	Removes legacy build-tag syntax.
`go.mod`	Updates test and indirect dependency requirements.

_{Review effort: Balanced}

aramprice · 2026-10-29T20:48:04Z

+	github.com/onsi/ginkgo/v2 v2.33.1
+	github.com/onsi/gomega v1.44.0
+	github.com/stretchr/testify v1.12.1
 	golang.org/x/sys v0.49.0
 )

 require (
-	github.com/Masterminds/semver/v3 v3.4.0 // indirect
-	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/go-logr/logr v1.4.3 // indirect
+	github.com/Masterminds/semver/v3 v3.5.0 // indirect
+	github.com/go-logr/logr v1.4.4 // indirect


Why two require() blocks?

Refresh test dependencies to unblock dependency bumps

004cd64

Copilot AI balanced review requested due to automatic review settings October 29, 2026 20:41

Copilot started reviewing on behalf of Alphasite October 29, 2026 20:42

View session

Copilot AI reviewed Oct 29, 2026

View reviewed changes

aramprice reviewed Oct 29, 2026

View reviewed changes

aramprice approved these changes Oct 29, 2026

View reviewed changes

Alphasite merged commit 74c2951 into master Oct 29, 2026
14 checks passed

Alphasite deleted the fix/bump-test-dependencies branch October 29, 2026 20:51

Navigation Menu

Repository navigation

Refresh test dependencies to unblock dependency bumps - #95

Refresh test dependencies to unblock dependency bumps#95
Alphasite merged 1 commit into
masterfrom
fix/bump-test-dependencies

Alphasite commented Oct 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

aramprice Oct 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Alphasite commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

aramprice Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alphasite commented Oct 29, 2026 •

edited

Loading