Skip to content

CI: Clean up pass constraints for promote job. - #191

Merged
ragaskar merged 1 commit into
windows-2019from
fix-pass-constraints
Sep 11, 2026
Merged

ragaskar merged 1 commit into
windows-2019from
fix-pass-constraints

Conversation

@ragaskar

Copy link
Copy Markdown
Contributor
  • The pass constraints for promote contained many redundant builds that caused the pipeline to render in an incredibly confusing way (and possibly exhibit undesired behavior?).
  • This commit simplifies the constraints so it's clear that promote takes the last set of inputs that successfully flowed through the print-release-candidate-info job.
  • Also, "restore' the # implies => aws-build-number note that was previously added to the wuts-aws-govcloud pass-constraint in several places on promote but got removed when it was copied to print-release-candidate-info (I am assuming this note is still accurate/relevant).

[TNZ-88995]
ai-assisted=yes

- The pass constraints for `promote` contained many redundant builds
  that caused the pipeline to render in an incredibly confusing way (and
  possibly exhibit undesired behavior?).
- This commit simplifies the constraints so it's clear that `promote`
  takes the last set of inputs that successfully flowed through the
  `print-release-candidate-info` job.
- Also, "restore' the `# implies => aws-build-number` note that was
  previously added to the wuts-aws-govcloud pass-constraint in several
  places on promote but got removed when it was copied to
  print-release-candidate-info (I am assuming this note is still
  accurate/relevant).

[TNZ-88995]
ai-assisted=yes

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@ragaskar
ragaskar requested a review from aramprice September 11, 2026 03:32
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 290a6c9e-0a07-4905-a32e-171a379725a3

📥 Commits

Reviewing files that changed from the base of the PR and between 6d86601 and bb70fef.

📒 Files selected for processing (1)
  • ci/pipelines/stemcells-windows.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pipeline adds comments that identify the aws-build-number implication of wuts-aws-govcloud. The promote job changes all get step prerequisites to passed: [print-release-candidate-info].

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to bb70f

Promotion continues to use a correlated release-candidate input set; no actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: simplifying the pass constraints for the promote job.
Description check ✅ Passed The description directly explains the redundant pass constraints, the updated promote behavior, and the restored aws-build-number note.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-pass-constraints

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ragaskar
ragaskar merged commit 49f9c7a into windows-2019 Sep 11, 2026
15 checks passed
@ragaskar
ragaskar deleted the fix-pass-constraints branch September 11, 2026 17:05
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants