Remove deprecated Ruby OpenStack CPI - #362
Conversation
Delete the Ruby CPI implementation, its BOSH packages, job, CI tasks,
developer scripts, and docs. The Go CPI is the sole implementation going
forward.
- Remove src/bosh_openstack_cpi/ (Ruby source + vendored gems)
- Remove packages/bosh_openstack_cpi/, packages/openstack-ruby-3.{1,4}/
- Remove jobs/openstack_cpi/ (keep jobs/openstack_cpi_golang/)
- Remove ci/tasks/run-unit-specs.{sh,yml} and run-lifecycle.{sh,yml}
- Remove scripts/check-ruby-version, rubocop-staged, test-unit, test-unit-erb
- Drop rubocop pre-commit hook from git-hooks/pre-commit
- Remove LFS filter rule for vendored gems from .gitattributes
- Remove Ruby prerequisites and test-unit sections from CONTRIBUTING.md
|
Important Review skippedToo many files! This PR contains 176 files, which is 76 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (176)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🔵 Needs a closer look
The retained USE_GOLANG_CPI=false deployment path still requests the deleted openstack_cpi job and will fail.
Pull request overview
Removes the deprecated Ruby OpenStack CPI so the Go CPI becomes the sole implementation.
Changes:
- Deletes Ruby CPI source, tests, vendored gems, BOSH job, and packages.
- Removes Ruby-specific scripts, CI tasks, hooks, and documentation.
- Removes the Git LFS rule used for vendored gems.
File summaries
| File | Description |
|---|---|
src/bosh_openstack_cpi/** |
Deletes the Ruby CPI implementation, tests, configuration, documentation, and vendored dependencies. |
packages/bosh_openstack_cpi/** |
Deletes the Ruby CPI BOSH package. |
packages/openstack-ruby-3.1/spec.lock |
Removes the obsolete Ruby runtime package lock. |
packages/openstack-ruby-3.4/spec.lock |
Removes the obsolete Ruby runtime package lock. |
jobs/openstack_cpi/** |
Deletes the Ruby CPI BOSH job and templates. |
ci/tasks/run-unit-specs.{sh,yml} |
Removes Ruby unit-test CI tasks. |
ci/tasks/run-lifecycle.{sh,yml} |
Removes Ruby lifecycle-test CI tasks. |
scripts/check-ruby-version |
Removes Ruby setup tooling. |
scripts/rubocop-staged |
Removes Ruby lint tooling. |
scripts/test-unit |
Removes the Ruby unit-test script. |
scripts/test-unit-erb |
Removes the Ruby template-test script. |
git-hooks/pre-commit |
Removes the RuboCop hook invocation. |
.gitattributes |
Removes Git LFS handling for vendored gems. |
CONTRIBUTING.md |
Removes Ruby prerequisites and test instructions. |
Review details
Suppressed comments (1)
jobs/openstack_cpi/spec:1
- Deleting this job leaves the exposed
USE_GOLANG_CPI=falsepath inci/tasks/deploy-manual-networking.{sh,yml}without the replacement ops file. That path still generates a manifest requestingopenstack_cpi, which is absent from the dev release, sobosh create-envwill fail. Since Go is now mandatory, remove the flag/false branch and always applyuse-golang-cpi.yml, or retain a compatible job alias.
- Files reviewed: 106/185 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aramprice
left a comment
There was a problem hiding this comment.
So exciting to see this, nice work!
Delete the Ruby CPI implementation, its BOSH packages, job, CI tasks, developer scripts, and docs. The Go CPI is the sole implementation going forward.