Repository navigation
Replace esbuild with rolldown - #1105
Closed
logan-gatlin wants to merge 1 commit into
Closed
logan-gatlin wants to merge 1 commit into
logan-gatlin wants to merge 1 commit into
Conversation
Collaborator
That's a good goal! Note that in #1103 we are able to avoid the esbuild step as well, using just plain modular output. So we entirely drop the bundler with that migration. While we could land this in the mean time, the sooner we can switch to the automated bindgen release version the better. |
Collaborator
Author
|
Nice! No bundler is even better than a Rust bundler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pros
There are 3 reasons I think this is a good idea:
Cons
My pet project is to make the Rust workers build pipeline 100% Rust. After this change the only non-Rust component will be wasm-opt as far as I'm aware.