Repository navigation
fix(worker-build): read the dependencies map from wasm-bindgen's package.json - #1096
Open
PedroRosalba wants to merge 1 commit into
Open
PedroRosalba wants to merge 1 commit into
PedroRosalba wants to merge 1 commit into
Conversation
…age.json `write_package_json` parsed the `package.json` that wasm-bindgen leaves in the output directory as a flat `HashMap<String, String>`. Since wasm-bindgen 0.2.94 (wasm-bindgen/wasm-bindgen#4091) that file is a real manifest, `{"dependencies": {...}}`, so any crate whose JS snippet pulls in an NPM package failed with `invalid type: map, expected a string`. Deserialize the `dependencies` object instead and ignore the other fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
write_package_jsonparses thepackage.jsonthat wasm-bindgen leaves in the output directory as a flatHashMap<String, String>. Since wasm-bindgen 0.2.94 (wasm-bindgen/wasm-bindgen#4091) that file is a real manifest,{"dependencies": {...}}, so any crate whose JS snippet imports an NPM package failsworker-buildwithinvalid type: map, expected a string.wasm-pack hit the same change (wasm-bindgen/wasm-pack#1420); this is the equivalent fix for worker-build.
Fix
Deserialize the
dependenciesobject and ignore the other fields. Crates without snippet dependencies are unaffected.Tests
Unit tests in
manifest.rsfor the new shape, the old flat shape, and a manifest withoutdependencies.Tested on macOS (Apple Silicon) only.
Fixes #1087