Repository navigation
fix(runtime-sdk): fix contextvars not being shared in WSGI streaming response - #288
Open
ryanking13 wants to merge 2 commits into
Open
ryanking13 wants to merge 2 commits into
ryanking13 wants to merge 2 commits into
Conversation
…treaming response
|
LGTM |
|
✅ Approved — The fix works: one copied context now covers calling the app, iterating it and closing it. The new tests check that values are shared within a stream, kept separate between concurrent streams, and reset when a stream is cancelled. No issues found. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🔒 Security: ✅ LGTMI found no security concerns. 📖 AGENTS.md: ✅ LGTMThis change does not need any AGENTS.md updates. 📋 Code Quality: ✅ LGTMI found no issues in this change.
⚡ Performance: ✅ LGTMI found no performance concerns. Running each chunk through 📝 Documentation: ✅ LGTMI found no documentation issues. Reviewed commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #287
WSGI streaming response use stack switching. However, they should use the same contextvars, since they are in the same request context.