chore: Harden pnpm usage in release workflow#6566
Open
erezrokah wants to merge 5 commits intocloudflare:mainfrom
Open
chore: Harden pnpm usage in release workflow#6566erezrokah wants to merge 5 commits intocloudflare:mainfrom
erezrokah wants to merge 5 commits intocloudflare:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Hardens the release pipeline’s Node tooling so CI and Docker builds use a consistent pnpm version (derived from package.json) and avoid ad-hoc tool downloads during the publish workflow.
Changes:
- Install
pnpmin thepublish-wrapperjob before runningesbuild, and runpnpm installso tooling can resolve from the workspace. - Update
Dockerfile.releaseto install apnpmversion derived frompackage.json’spackageManagerfield.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Dockerfile.release |
Installs pnpm based on the repo’s packageManager field before running pnpm install and the Bazel build. |
.github/workflows/release.yml |
Adds pnpm/action-setup + pnpm install to the publish-wrapper job prior to npx esbuild usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Addressed review comments:
|
- Add pnpm setup, caching, and install step to publish-wrapper job so npx esbuild resolves from the lockfile instead of downloading on-the-fly - Derive pnpm version from packageManager field in Dockerfile.release instead of using pnpm@latest, with validation
erezrokah
force-pushed
the
claude/pnpm-hardening
branch
from
45e76f2 to
5b60090
Compare
penalosa
reviewed
Apr 15, 2026
Co-authored-by: Somhairle MacLeòid <samuel@macleod.space>
erezrokah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure esbuild resolves from the lockfile in the publish-wrapper job by installing dependencies with pnpm before running
npx esbuild.