chore: Restrict bonk workflows to org members#6564
Open
erezrokah wants to merge 2 commits intocloudflare:mainfrom
Open
chore: Restrict bonk workflows to org members#6564erezrokah wants to merge 2 commits intocloudflare:mainfrom
erezrokah wants to merge 2 commits intocloudflare:mainfrom
Conversation
Add author_association check to issue_comment triggers in bonk and bigbonk workflows to prevent external users from invoking bonk with write permissions.
|
All contributors have signed the CLA ✍️ ✅ |
erezrokah
changed the title
Author
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Pull request overview
This PR tightens access control for the “bonk” automation by restricting who can invoke the workflows via comment commands, reducing the risk of external users triggering write-permission actions.
Changes:
- Add an
author_associationgate to thebonkworkflow jobif:condition. - Add an
author_associationgate to thebigbonkworkflow jobif:condition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/bonk.yml | Adds an author_association check to restrict command invocation to trusted users. |
| .github/workflows/bigbonk.yml | Adds an author_association check to restrict command invocation to trusted users. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| bonk: | ||
| if: github.event.sender.type != 'Bot' && (contains(github.event.comment.body, '/bonk') || contains(github.event.comment.body, '@ask-bonk')) | ||
| if: github.event.sender.type != 'Bot' && (contains(github.event.comment.body, '/bonk') || contains(github.event.comment.body, '@ask-bonk')) && (github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'OWNER' || github.event.comment.author_association == 'COLLABORATOR') |
| jobs: | ||
| bonk: | ||
| if: github.event.sender.type != 'Bot' && contains(github.event.comment.body, '/bigbonk') | ||
| if: github.event.sender.type != 'Bot' && contains(github.event.comment.body, '/bigbonk') && (github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'OWNER' || github.event.comment.author_association == 'COLLABORATOR') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
author_associationcheck toissue_commenttriggers in bonk and bigbonk workflows to prevent external users from invoking bonk with write permissions to the repository.