You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The change is straightforward and correct. The C++ signature already accepts jsg::Optional<kj::Maybe<kj::String>>, meaning undefined is valid at runtime. The PR simply updates the JSG_TS_OVERRIDE blocks in actor.h and the generated type snapshots to match. Let me just double-check that both JSG_TS_OVERRIDE branches (the getDurableObjectGetExisting and the else branch) were both updated:
The diff shows both branches at lines 272 and 278 were updated. The generated snapshots in types/generated-snapshot/ for both latest and experimental are also updated consistently.
This is a correct, minimal fix that aligns TypeScript types with the already-existing C++ behavior. No backward compatibility concern (it only widens the accepted type). No security concern. No missing compat flag needed (the C++ behavior is unchanged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6551
Update the javascript override to match the underlying c++ function.