Skip to content

Allow undefined jurisdiction param#6554

Open
maxmcd wants to merge 1 commit intomainfrom
mmcdonnell/allow-undefined-jurisdiction-param
Open

Allow undefined jurisdiction param#6554
maxmcd wants to merge 1 commit intomainfrom
mmcdonnell/allow-undefined-jurisdiction-param

Conversation

@maxmcd
Copy link
Copy Markdown
Contributor

@maxmcd maxmcd commented Apr 10, 2026

closes #6551

Update the javascript override to match the underlying c++ function.

@maxmcd maxmcd requested review from a team as code owners April 10, 2026 19:13
@maxmcd maxmcd requested a review from edmundhung April 10, 2026 19:13
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 10, 2026

The change is straightforward and correct. The C++ signature already accepts jsg::Optional<kj::Maybe<kj::String>>, meaning undefined is valid at runtime. The PR simply updates the JSG_TS_OVERRIDE blocks in actor.h and the generated type snapshots to match. Let me just double-check that both JSG_TS_OVERRIDE branches (the getDurableObjectGetExisting and the else branch) were both updated:

The diff shows both branches at lines 272 and 278 were updated. The generated snapshots in types/generated-snapshot/ for both latest and experimental are also updated consistently.

This is a correct, minimal fix that aligns TypeScript types with the already-existing C++ behavior. No backward compatibility concern (it only widens the accepted type). No security concern. No missing compat flag needed (the C++ behavior is unchanged).

LGTM

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing types for undefined jurisdiction

3 participants